Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-06 Thread Patrick McHardy
Stephen Hemminger wrote: On Wed, 06 Jun 2007 01:17:11 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: If you want I'll extend existing bridge netlink to use these. Are you talking about brige-port information or bridge device configuration? So far the API is not suitable for anything that

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-06 Thread Eric W. Biederman
+static int rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) +{ + struct rtnl_link_ops *ops; + struct net_device *dev; + struct ifinfomsg *ifm; + char name[MODULE_NAME_LEN]; + char ifname[IFNAMSIZ]; + struct nlattr *tb[IFLA_MAX+1]; + struct

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-06 Thread Patrick McHardy
Eric W. Biederman wrote: + if (linkinfo[IFLA_INFO_NAME]) { + nla_strlcpy(name, linkinfo[IFLA_INFO_NAME], sizeof(name)); + ops = rtnl_link_ops_get(name); Ugh. Shouldn't we have the request_module logic here? Otherwise it looks like we can skip the validate method

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-06 Thread Eric W. Biederman
Patrick McHardy [EMAIL PROTECTED] writes: Eric W. Biederman wrote: +if (linkinfo[IFLA_INFO_NAME]) { +nla_strlcpy(name, linkinfo[IFLA_INFO_NAME], sizeof(name)); +ops = rtnl_link_ops_get(name); Ugh. Shouldn't we have the request_module logic here? Otherwise it

[RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread Patrick McHardy
[RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 0323e7d1e7d5042492684264cfcba6d7ff55c473 tree 161530836d43b39ddef42a2c2b48b82187580e3c parent

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:12:57 +0200 (MEST) [RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Looks mostly fine, perhaps you can make even more

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:12:57 +0200 (MEST) [RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Looks mostly fine, perhaps you

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2007 16:12:57 +0200 (MEST) Patrick McHardy [EMAIL PROTECTED] wrote: [RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] If you want I'll extend existing bridge netlink to

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread Patrick McHardy
Stephen Hemminger wrote: On Tue, 5 Jun 2007 16:12:57 +0200 (MEST) Patrick McHardy [EMAIL PROTECTED] wrote: [RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] If you want I'll extend

Re: [RFC RTNETLINK 04/09]: Link creation API

2007-06-05 Thread Stephen Hemminger
On Wed, 06 Jun 2007 01:17:11 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Tue, 5 Jun 2007 16:12:57 +0200 (MEST) Patrick McHardy [EMAIL PROTECTED] wrote: [RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software