Re: [RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-25 Thread Gianluca Borello
On Wed, Apr 25, 2018 at 8:34 AM Daniel Borkmann wrote: > I've applied this fix to bpf tree, thanks Gianluca! Thank you all for the quick review, really appreciated!

Re: [RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-25 Thread Daniel Borkmann
On 04/25/2018 07:42 AM, Gianluca Borello wrote: > Commit 2a5418a13fcf ("bpf: improve dead code sanitizing") replaced dead > code with a series of ja-1 instructions, for safety. That made JIT > compilation much more complex for some BPF programs. One instance of such > programs is, for example: >

Re: [RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-25 Thread Alexei Starovoitov
On Wed, Apr 25, 2018 at 05:42:16AM +, Gianluca Borello wrote: > Commit 2a5418a13fcf ("bpf: improve dead code sanitizing") replaced dead > code with a series of ja-1 instructions, for safety. That made JIT > compilation much more complex for some BPF programs. One instance of such > programs

Re: [RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-25 Thread Daniel Borkmann
On 04/25/2018 07:42 AM, Gianluca Borello wrote: > Commit 2a5418a13fcf ("bpf: improve dead code sanitizing") replaced dead > code with a series of ja-1 instructions, for safety. That made JIT > compilation much more complex for some BPF programs. One instance of such > programs is, for example:

[RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-24 Thread Gianluca Borello
Commit 2a5418a13fcf ("bpf: improve dead code sanitizing") replaced dead code with a series of ja-1 instructions, for safety. That made JIT compilation much more complex for some BPF programs. One instance of such programs is, for example: bool flag = false ... /* A bunch of other code */ ... if