Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-12-04 Thread Marc Gonzalez
On 27/11/2017 08:48, Geert Uytterhoeven wrote: > The MDIO bus callback is not called from the network device ... > >>> smsc hangs of [fec1.bus, which is started only here ---> >>> >>> Workqueue: events_power_efficient phy_state_machine >>> [] (unwind_backtrace) from []

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-11-26 Thread Geert Uytterhoeven
Hi Florian, On Mon, Nov 27, 2017 at 5:05 AM, Florian Fainelli wrote: > On 11/06/2017 07:50 AM, Geert Uytterhoeven wrote: >> On Tue, Oct 31, 2017 at 5:33 PM, Florian Fainelli >> wrote: >>> On 10/31/2017 08:26 AM, Geert Uytterhoeven wrote: On Mon,

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-11-26 Thread Florian Fainelli
Hi Geert, On 11/06/2017 07:50 AM, Geert Uytterhoeven wrote: > Hi Florian, > > On Tue, Oct 31, 2017 at 5:33 PM, Florian Fainelli > wrote: >> On 10/31/2017 08:26 AM, Geert Uytterhoeven wrote: >>> On Mon, Oct 30, 2017 at 5:09 PM, Florian Fainelli >>>

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-11-06 Thread Geert Uytterhoeven
Hi Florian, On Tue, Oct 31, 2017 at 5:33 PM, Florian Fainelli wrote: > On 10/31/2017 08:26 AM, Geert Uytterhoeven wrote: >> On Mon, Oct 30, 2017 at 5:09 PM, Florian Fainelli >> wrote: >>> On 10/30/2017 06:56 AM, Geert Uytterhoeven wrote: On Thu,

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-10-31 Thread Florian Fainelli
On 10/31/2017 08:26 AM, Geert Uytterhoeven wrote: > Hi Florian, > > On Mon, Oct 30, 2017 at 5:09 PM, Florian Fainelli > wrote: >> On 10/30/2017 06:56 AM, Geert Uytterhoeven wrote: >>> On Thu, Oct 26, 2017 at 1:21 AM, Florian Fainelli >>> wrote:

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-10-31 Thread Geert Uytterhoeven
Hi Florian, On Mon, Oct 30, 2017 at 5:09 PM, Florian Fainelli wrote: > On 10/30/2017 06:56 AM, Geert Uytterhoeven wrote: >> On Thu, Oct 26, 2017 at 1:21 AM, Florian Fainelli >> wrote: >>> Marc reported that he was not getting the PHY library

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-10-30 Thread Florian Fainelli
On 10/30/2017 06:56 AM, Geert Uytterhoeven wrote: > Hi Florian, > > On Thu, Oct 26, 2017 at 1:21 AM, Florian Fainelli > wrote: >> Marc reported that he was not getting the PHY library adjust_link() >> callback function to run when calling phy_stop() + phy_disconnect() >>

Re: [RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-10-30 Thread Geert Uytterhoeven
Hi Florian, On Thu, Oct 26, 2017 at 1:21 AM, Florian Fainelli wrote: > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we set the state machine

[RFC net-next 4/4] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-10-25 Thread Florian Fainelli
Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen because we set the state machine to PHY_HALTED but we don't get to run it to process this state past that point. Fix this with a