We enable TSO to get a lot of data at once to build A-MSDUs.
Our hardware doesn't have (yet) TCP CSUM offload, so we do
it manually. TSO won't be enabled on hardware that don't
support CSUM offload in release code, computing TCP CSUM
in the driver is just a way to start coding the flows.
This is
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
We could have enabled A-MSDU based on xmit-more, but the
rationale of using LSO is that when using pfifo-fast,
the Qdisc gets one packet and dequeues is straight away
which limits the possibility to get a lot of packets at
once. (Am
Hi Eric,
First, thank you a lot for your comments.
On 08/19/2015 05:14 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
We could have enabled A-MSDU based on xmit-more, but the
rationale of using LSO is that when using pfifo-fast,
the Qdisc gets one
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought with another
(good?) reason to use LSO. LSO gives me the guarantee that the packet is
directed to one peer, which might not be the case with xmit_more since
On 08/19/2015 07:08 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought with another
(good?) reason to use LSO. LSO gives me the guarantee that the packet is
directed to one peer,
On Wed, 2015-08-19 at 17:00 +, Grumbach, Emmanuel wrote:
On 08/19/2015 07:08 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought with another
(good?) reason to use LSO.
On Wed, 2015-08-19 at 17:56 +, Grumbach, Emmanuel wrote:
So I feel that making net/core/tso.c more complicated just because of
our craziness seems an overkill to me.
I'll try a bit harder to see how I can use net/core/tso.c, but I have to
say I am pessimistic.
net/core/tso.c is WIP,
On 08/19/2015 09:02 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 17:56 +, Grumbach, Emmanuel wrote:
So I feel that making net/core/tso.c more complicated just because of
our craziness seems an overkill to me.
I'll try a bit harder to see how I can use net/core/tso.c, but I have to
On 08/19/2015 08:20 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 17:00 +, Grumbach, Emmanuel wrote:
On 08/19/2015 07:08 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought
