On Fri, 10 Nov 2006 22:30:43 +0100
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> :
> [...]
> > skb_linearize is documented to free skb on failure.
>
> __skb_linearize
> -> __pskb_pull_tail
>-> pskb_expand_head
> [...]
> data = kmalloc(size +
Stephen Hemminger <[EMAIL PROTECTED]> :
[...]
> skb_linearize is documented to free skb on failure.
__skb_linearize
-> __pskb_pull_tail
-> pskb_expand_head
[...]
data = kmalloc(size + sizeof(struct skb_shared_info), gfp_mask);
if (!data)
goto nodata;
On Fri, 10 Nov 2006 22:03:43 +0100
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Dale Farnsworth <[EMAIL PROTECTED]> :
> [...]
> > Can you provide more detail about the leak?
>
> + if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) {
> + stats->tx_dropped++;
> +
Dale Farnsworth <[EMAIL PROTECTED]> :
[...]
> Can you provide more detail about the leak?
+ if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) {
+ stats->tx_dropped++;
+ if (net_ratelimit())
+ printk(KERN_DEBUG "%s: failed to lineariz
In article <[EMAIL PROTECTED]> you write:
Ueimor <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> :
> [...]
> > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> [...]
>
> It seems to propagate a leak from the initial codebase.
Can you provide more detail abou
Stephen Hemminger <[EMAIL PROTECTED]> :
[...]
> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> index 9997081..4052bfe 100644
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -1191,25 +1191,23 @@ static int mv643xx_eth_start_xmit(struct
> struct ne
On Fri, 10 Nov 2006 12:17:45 -0700
Erik Andersen <[EMAIL PROTECTED]> wrote:
> I have a Pegasos2 powerpc system acting as my home server. With
> 2.6.16.x it was 100% stable and I had months of uptime, rebooting
> only to periodically apply security updates to the kernel.
>
> With 2.6.17 and 2.6.1
