RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Jan Beulich
el >> Cc: xen-de...@lists.xenproject.org; Jan Beulich; netdev@vger.kernel.org >> Subject: Re: [Xen-devel] [PATCH] xen-netback: correct return value checks >> on xenbus_scanf() >> >> On 07/07/16 11:35, Wei Liu wrote: >> > On Thu, Jul 07, 2016 at 10:58:16A

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
e: [Xen-devel] [PATCH] xen-netback: correct return value checks > on xenbus_scanf() > > On 07/07/16 11:35, Wei Liu wrote: > > On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: > >> On 07/07/16 08:57, Jan Beulich wrote: > >>> Only a positive retu

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 07 July 2016 11:41 > To: Wei Liu; David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: RE: [Xen-devel] [PATCH] xen-netback: correct return value che

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread David Vrabel
On 07/07/16 11:35, Wei Liu wrote: > On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: >> On 07/07/16 08:57, Jan Beulich wrote: >>> Only a positive return value indicates success. >> >> This is not correct. >> > > Do you mean the commit message is not correct or the code is not >

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
[Xen-devel] [PATCH] xen-netback: correct return value checks > on xenbus_scanf() > > On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: > > On 07/07/16 08:57, Jan Beulich wrote: > > > Only a positive return value indicates success. > > > > This

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Wei Liu
On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: > On 07/07/16 08:57, Jan Beulich wrote: > > Only a positive return value indicates success. > > This is not correct. > Do you mean the commit message is not correct or the code is not correct? If it is the formal, do you have any

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread David Vrabel
On 07/07/16 08:57, Jan Beulich wrote: > Only a positive return value indicates success. This is not correct. David

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 07 July 2016 08:57 > To: Wei Liu > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org > Subject: [Xen-devel] [PATCH] xen-netback: correc