Re: [bpf-next V2 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg

2017-12-27 Thread Jesper Dangaard Brouer
m; Dept-Eng Everest Linux L2 > engeverestlinu...@cavium.com>; michael.c...@broadcom.com > > Subject: [bpf-next V2 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro > > xdp_rxq_info_is_reg > > > > The driver code qede_free_fp_array() depend on kfree() can be cal

RE: [bpf-next V2 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg

2017-12-27 Thread Chopra, Manish
er.kernel.org; Jesper Dangaard Brouer > <bro...@redhat.com>; Elior, Ariel <ariel.el...@cavium.com>; > dsah...@gmail.com; go...@broadcom.com; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com>; michael.c...@broadcom.com > Subject: [bpf-next V2 PATCH 05/14] xdp/qe

[bpf-next V2 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg

2017-12-22 Thread Jesper Dangaard Brouer
The driver code qede_free_fp_array() depend on kfree() can be called with a NULL pointer. This stems from the qede_alloc_fp_array() function which either (kz)alloc memory for fp->txq or fp->rxq. This also simplifies error handling code in case of memory allocation failures, but xdp_rxq_info_unreg