Re: [e1000]: flow control on by default - good idea really?

2006-10-18 Thread jamal
On Tue, 2006-17-10 at 14:02 -0700, Auke Kok wrote: For now, we should really report the FC status in e1000 at link up time. Jamal: this should help you out for now, I'll send something like this upstream later on. Thanks - this puts you at par with the tg3 at least. On Tue, 2006-17-10

Re: [e1000]: flow control on by default - good idea really?

2006-10-18 Thread Auke Kok
jamal wrote: On Tue, 2006-17-10 at 14:02 -0700, Auke Kok wrote: For now, we should really report the FC status in e1000 at link up time. Jamal: this should help you out for now, I'll send something like this upstream later on. Thanks - this puts you at par with the tg3 at least. On Tue,

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread jamal
On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control capability. Auke, can you also check this as well? Just found this in my

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread Auke Kok
jamal wrote: On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control capability. Auke, can you also check this as well? Just found this

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread Stephen Hemminger
On Tue, 17 Oct 2006 09:05:31 -0400 jamal [EMAIL PROTECTED] wrote: On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread Auke Kok
jamal wrote: On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control capability. Auke, can you also check this as well? Just found

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 17 Oct 2006 09:05:31 -0400 It sounds to me that ethttool needs to have this semantic fix. IOW, ethttool doesnt differentiate the two items: a) advertised parameters. b) link partner negotiated parameters. and instead #a becomes #b after negotiation.

Re: Bug in e1000 + semantics of flow control WAS(Re: [e1000]: flow control on by default - good idea really?

2006-08-03 Thread jamal
To the good folks at Intel: Do you need more info on how to reproduce the issue below? Note, there are 2 issues - one being a larger ethtool semantic issue and the other being what i perceive to be a bug in the e1000. cheers, jamal On Thu, 2006-20-07 at 16:15 -0400, jamal wrote: I went back

Bug in e1000 + semantics of flow control WAS(Re: [e1000]: flow control on by default - good idea really?

2006-07-20 Thread jamal
I went back to this today. I am typing this from a scribbled sticky note in a big hurry - but i still believe I took the correct notes. It does seem there is no distinction between what ethernet advertises for flow control capability vs what it ends up negotiating with its partner i.e there is

Re: [e1000]: flow control on by default - good idea really?

2006-07-07 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 06 Jul 2006 09:03:38 -0400 On Wed, 2006-05-07 at 22:45 +0200, Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum

Re: [e1000]: flow control on by default - good idea really?

2006-07-07 Thread jamal
On Thu, 2006-06-07 at 23:59 -0700, David Miller wrote: It's autonegotiated, check you kernel message logs when the link came up, you'll see this: tg3: eth0: Flow control is on for TX and on for RX. yikes - yes, this would be it. I could be wrong and i will double check: I think when

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread jamal
On Wed, 2006-05-07 at 22:45 +0200, Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread Auke Kok
jamal wrote: On Wed, 2006-05-07 at 22:45 +0200, Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: Flow control has been on by default in the tg3 driver since the beginning, Are you sure about this Dave?;- because I do have a tg3 on my laptop. [EMAIL

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread jamal
On Thu, 2006-06-07 at 11:25 -0700, Auke Kok wrote: jamal wrote: [EMAIL PROTECTED]:~/Desktop/maemo$ sudo ethtool -a eth0 Pause parameters for eth0: Autonegotiate: on RX: off TX: off mine says it's on :) Dell D610: [EMAIL PROTECTED]:~$ sudo lspci | grep -i

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread Michael Chan
Jamal wrote: Dell D610: [EMAIL PROTECTED]:~$ sudo lspci | grep -i bcm :02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5751 Gigabit Ethernet PCI Express (rev 01) This is Broadcom tg3 hardware. Are we talking about e1000 or tg3? Flow control advertisement has always

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread Auke Kok
jamal wrote: On Tue, 2006-04-07 at 13:11 -0400, jamal wrote: I have a device connected to a e1000 that was erroneously advertising both tx/rx flow control but wasnt properly reacting to it. The default setup on the e1000 has rx flow control turned on. I was sending at wire rate gige from the

[e1000]: flow control on by default - good idea really?

2006-07-05 Thread Robert Olsson
jamal writes: The default setup on the e1000 has rx flow control turned on. I was sending at wire rate gige from the device - which is about 1.48Mpps. The e1000 was in turn sending me flow control packets as per default/expected behavior. Unfortunately, it was sending a very large

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 13:11:56 -0400 Clearly, this is a bad thing. Yes, the device in the first instance was at fault. But i have argued in the past that NAPI does just fine without flow control being turned on, so even chewing 5% of bandwidth on flow control is

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has been on by default in the tg3 driver since the beginning, maybe e1000 only recently started to behave that way but it's the right thing

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread Auke Kok
David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has been on by default in the tg3 driver since the beginning, maybe e1000 only recently started to behave that way

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread Krzysztof Oledzki
On Wed, 5 Jul 2006, Auke Kok wrote: jamal wrote: On Tue, 2006-04-07 at 13:11 -0400, jamal wrote: I have a device connected to a e1000 that was erroneously advertising both tx/rx flow control but wasnt properly reacting to it. The default setup on the e1000 has rx flow control turned on. I

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread Krzysztof Oledzki
On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has been on by default in the tg3 driver since the beginning, maybe e1000

Re: [e1000]: flow control on by default - good idea really?

2006-07-05 Thread Auke Kok
Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has been on by default in the tg3 driver since the

[e1000]: flow control on by default - good idea really?

2006-07-04 Thread jamal
CCing anybody who may have stakes on this. Ignore the email if this doesnt interest you. Ok, folks - i had deferred this discussion but it bit me in the ass. I just spend an hour debugging it (and in the process blew up a gbic i borrowed, so my day aint going well since i actually have to pay

Re: [e1000]: flow control on by default - good idea really?

2006-07-04 Thread jamal
On Tue, 2006-04-07 at 13:11 -0400, jamal wrote: CCing anybody who may have stakes on this. Ignore the email if this doesnt interest you. Ok, folks - i had deferred this discussion but it bit me in the ass. I just spend an hour debugging it (and in the process blew up a gbic i borrowed, so my