Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Ben Hutchings
On Mon, 2016-06-27 at 00:02 +0200, Ben Hutchings wrote: > On Sun, 2016-06-26 at 09:40 -0700, Vidya Sagar Ravipati wrote: > > On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: > [...] > > > This looks very similar to sff8472_diags, only with the actual values > > >

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Ben Hutchings
On Sun, 2016-06-26 at 09:40 -0700, Vidya Sagar Ravipati wrote: > On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: [...] > > This looks very similar to sff8472_diags, only with the actual values > > separated from the arrays of thresholds. > > > > Can the structure and

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Rami Rosen
Hi Vidya, Thanks a lot for your your work! Here are my 2 cents: > + /* SFP voltage in 0.1mV units */ > + __u16 sfp_voltage; > + /* SFP Temp in 16-bit signed 1/256 Celcius */ > + __s16 sfp_temp; > + /* [4] tables are low/high warn, low/high alarm */ You already had

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Vidya Sagar Ravipati
On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: > On Mon, 2016-06-13 at 16:27 -0700, Vidya Sagar Ravipati wrote: >> From: Vidya Sagar Ravipati >> >> This patch series provides following support >> a) Reorganized fields based out of SFF-8024

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Ben Hutchings
On Mon, 2016-06-13 at 16:27 -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > This patch series provides following support > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ >    Encoding/Connector types which are common across

[ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-13 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into