Re: [iproute PATCH] rdma: Fix for ineffective check in add_filter()

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 13:41:54 +0200 Phil Sutter wrote: > With 'name' field defined as array in struct filters, it will always > contain a value irrespective of whether a name was assigned or not. > > Fix this by turning the field into a const char pointer. > > Fixes: 8cd644095842a ("devlink:

Re: [iproute PATCH] rdma: Fix for ineffective check in add_filter()

2018-10-18 Thread Phil Sutter
Hi, On Thu, Oct 18, 2018 at 09:27:47AM -0600, David Ahern wrote: > On 10/18/18 5:41 AM, Phil Sutter wrote: > > With 'name' field defined as array in struct filters, it will always > > contain a value irrespective of whether a name was assigned or not. > > > > Fix this by turning the field into a

Re: [iproute PATCH] rdma: Fix for ineffective check in add_filter()

2018-10-18 Thread David Ahern
On 10/18/18 5:41 AM, Phil Sutter wrote: > With 'name' field defined as array in struct filters, it will always > contain a value irrespective of whether a name was assigned or not. > > Fix this by turning the field into a const char pointer. > > Fixes: 8cd644095842a ("devlink: Add support for

[iproute PATCH] rdma: Fix for ineffective check in add_filter()

2018-10-18 Thread Phil Sutter
With 'name' field defined as array in struct filters, it will always contain a value irrespective of whether a name was assigned or not. Fix this by turning the field into a const char pointer. Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction") Signed-off-by: Phil