RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 1:07 PM > To: 张胜举 <zhangshen...@cmss.chinamobile.com>; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump >

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 9:50 PM, 张胜举 wrote: > No, when dump request must be processed by multiple 'recv/recvmsg' system > calls, > idx stores which dev/neigh the previous call have processed, so that next > call will scan > from the right place. I have tested multiple calls and I do not see redundant

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 11:10 AM > To: 张胜举 <zhangshen...@cmss.chinamobile.com>; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
n...@cmss.chinamobile.com>; >>> netdev@vger.kernel.org >>> Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump >>> >>> On 11/27/16 7:34 PM, 张胜举 wrote: >>>>> -Original Message- >>>>> From: David Ahern [mailto:d...@cum

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 7:53 PM, 张胜举 wrote: > > >> -Original Message- >> From: David Ahern [mailto:d...@cumulusnetworks.com] >> Sent: Monday, November 28, 2016 10:39 AM >> To: 张胜举 <zhangshen...@cmss.chinamobile.com>; >> netdev@vger.kernel.org >> Subje

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:39 AM > To: 张胜举 <zhangshen...@cmss.chinamobile.com>; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump >

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 7:34 PM, 张胜举 wrote: >> -Original Message- >> From: David Ahern [mailto:d...@cumulusnetworks.com] >> Sent: Monday, November 28, 2016 10:10 AM >> To: Zhang Shengju <zhangshen...@cmss.chinamobile.com>; >> netdev@vger.kernel.org >> Subje

RE: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread 张胜举
> -Original Message- > From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, November 28, 2016 10:10 AM > To: Zhang Shengju <zhangshen...@cmss.chinamobile.com>; > netdev@vger.kernel.org > Subject: Re: [net,v2] neigh: fix the loop index error in neigh

Re: [net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread David Ahern
On 11/27/16 6:32 PM, Zhang Shengju wrote: > Loop index in neigh dump function is not updated correctly under some > circumstances, this patch will fix it. What's an example? > > Fixes: 16660f0bd9 ("net: Add support for filtering neigh dump by device > index") > Fixes: 21fdd092ac ("net: Add

[net,v2] neigh: fix the loop index error in neigh dump

2016-11-27 Thread Zhang Shengju
Loop index in neigh dump function is not updated correctly under some circumstances, this patch will fix it. Fixes: 16660f0bd9 ("net: Add support for filtering neigh dump by device index") Fixes: 21fdd092ac ("net: Add support for filtering neigh dump by master device") Signed-off-by: Zhang