Re: [PATCH net] virtio-net: serialize tx routine during reset

2017-06-29 Thread David Miller
From: Jason Wang Date: Wed, 28 Jun 2017 09:51:03 +0800 > We don't hold any tx lock when trying to disable TX during reset, this > would lead a use after free since ndo_start_xmit() tries to access > the virtqueue which has already been freed. Fix this by using >

Re: [net] virtio-net: serialize tx routine during reset

2017-06-27 Thread McCabe, Robert J
Acked-by: Robert McCabe

Re: [PATCH net] virtio-net: serialize tx routine during reset

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 09:51:03AM +0800, Jason Wang wrote: > We don't hold any tx lock when trying to disable TX during reset, this > would lead a use after free since ndo_start_xmit() tries to access > the virtqueue which has already been freed. Fix this by using > netif_tx_disable() before

[PATCH net] virtio-net: serialize tx routine during reset

2017-06-27 Thread Jason Wang
We don't hold any tx lock when trying to disable TX during reset, this would lead a use after free since ndo_start_xmit() tries to access the virtqueue which has already been freed. Fix this by using netif_tx_disable() before freeing the vqs, this could make sure no tx after vq freeing.