Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-21 Thread santosh.shilim...@oracle.com
On 2/21/17 6:29 AM, David Laight wrote: The entire file should use the proper "__uX" kernel types rather than the uint* ones. The uint* ones are part of the C standard :-) Should have been uint*_t :-)

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-21 Thread Edward Cree
On 21/02/17 14:29, David Laight wrote: >> The entire file should use the proper "__uX" kernel types >> rather than the uint* ones. > The uint* ones are part of the C standard :-) > > David > ... which is exactly why we can't use them. http://yarchive.net/comp/linux/kernel_headers.html#17

RE: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-21 Thread David Laight
> The entire file should use the proper "__uX" kernel types > rather than the uint* ones. The uint* ones are part of the C standard :-) David

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-20 Thread David Miller
From: Sowmini Varadhan Date: Mon, 20 Feb 2017 10:37:22 -0500 > On (02/20/17 10:19), David Miller wrote: >> >> The correct fix it to use "__u8", "__u64", etc. > > So the rest of rds.h uses uint8_t, uint32_t etc > Perhaps (I'm not sure of the origins) this was

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-20 Thread Sowmini Varadhan
On (02/20/17 10:19), David Miller wrote: > > The correct fix it to use "__u8", "__u64", etc. So the rest of rds.h uses uint8_t, uint32_t etc Perhaps (I'm not sure of the origins) this was because of the shared OpenIB.org BSD license etc using __u8 in one place and uint8_t in another would seem

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-20 Thread David Miller
From: Santosh Shilimkar Date: Fri, 17 Feb 2017 19:15:47 -0800 > From: Santosh Shilimkar > > rds.h is exported to /usr/include/rds.h, so u8, u64 leads to > errors like below. > > /usr/include/linux/rds.h:197: error: expected

[net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-17 Thread Santosh Shilimkar
From: Santosh Shilimkar rds.h is exported to /usr/include/rds.h, so u8, u64 leads to errors like below. /usr/include/linux/rds.h:197: error: expected specifier-qualifier-list before 'u8' /usr/include/linux/rds.h:202: error: expected specifier-qualifier-list before 'u8'