Re: [net-next][PATCH] net/ipv4: fix a net leak

2018-10-25 Thread David Ahern
On 10/25/18 12:43 PM, Bjørn Mork wrote: > > inet_valid_dump_ifaddr_req() will bail out with an error, but only > *after* setting fillargs->netnsid: > > if (i == IFA_TARGET_NETNSID) { > struct net *net; > > fillargs->netnsid =

Re: [net-next][PATCH] net/ipv4: fix a net leak

2018-10-25 Thread Bjørn Mork
David Ahern writes: > On 10/24/18 9:02 AM, David Ahern wrote: >> On 10/24/18 3:36 AM, Li RongQing wrote: >>> put net when input a invalid ifindex, otherwise it will be leaked >>> >>> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a >>> specific device") >>> Cc: David Ahern

Re: [net-next][PATCH] net/ipv4: fix a net leak

2018-10-24 Thread David Ahern
On 10/24/18 9:02 AM, David Ahern wrote: > On 10/24/18 3:36 AM, Li RongQing wrote: >> put net when input a invalid ifindex, otherwise it will be leaked >> >> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a >> specific device") >> Cc: David Ahern >> Signed-off-by: Zhang Yu

Re: [net-next][PATCH] net/ipv4: fix a net leak

2018-10-24 Thread David Ahern
On 10/24/18 3:36 AM, Li RongQing wrote: > put net when input a invalid ifindex, otherwise it will be leaked > > Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a > specific device") > Cc: David Ahern > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing > --- >

[net-next][PATCH] net/ipv4: fix a net leak

2018-10-24 Thread Li RongQing
put net when input a invalid ifindex, otherwise it will be leaked Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a specific device") Cc: David Ahern Signed-off-by: Zhang Yu Signed-off-by: Li RongQing --- net/ipv4/devinet.c | 4 +++- 1 file changed, 3 insertions(+), 1