Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-13 Thread Jesper Dangaard Brouer
On Thu, 13 Aug 2015 03:13:40 +0200 Phil Sutter p...@nwl.cc wrote: On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: In general 'changing the default' may be an acceptable thing, but then it needs to strongly justified. How much performance does it bring? A quick test

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-13 Thread Phil Sutter
On Thu, Aug 13, 2015 at 03:10:33PM +0200, Jesper Dangaard Brouer wrote: On Thu, 13 Aug 2015 03:13:40 +0200 Phil Sutter p...@nwl.cc wrote: On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: In general 'changing the default' may be an acceptable thing, but then it

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-12 Thread Eric Dumazet
On Tue, 2015-08-11 at 18:13 -0700, Alexei Starovoitov wrote: Also why introduce the flag? Why not just add 'tx_queue_len = 0;' to veth_setup() like the whole bunch of devices do? Sigh. Because some people install htb or pfifo on veth, leaving tx_queue_len unchanged. If you install htb while

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-12 Thread Phil Sutter
On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: On Tue, Aug 11, 2015 at 06:23:35PM +0200, Phil Sutter wrote: I have an unfinished solution in the oven, but being kept busy with other things for now. The action plan is as follows: 1) Introduce IFF_NO_QUEUE

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-11 Thread Alexei Starovoitov
On Tue, Aug 11, 2015 at 06:23:35PM +0200, Phil Sutter wrote: I have an unfinished solution in the oven, but being kept busy with other things for now. The action plan is as follows: 1) Introduce IFF_NO_QUEUE net_device-priv_flag. 2) Have attach_default_qdiscs() and

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-11 Thread Phil Sutter
On Tue, Aug 11, 2015 at 05:48:07PM +0200, Jesper Dangaard Brouer wrote: On Wed, 29 Jul 2015 14:37:31 -0700 (PDT) David Miller da...@davemloft.net wrote: [...] Which is that there are devices (virtual or whatever) which don't want a qdisc attached no matter what. Flag those devices as

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-11 Thread Jesper Dangaard Brouer
On Wed, 29 Jul 2015 14:37:31 -0700 (PDT) David Miller da...@davemloft.net wrote: [...] Which is that there are devices (virtual or whatever) which don't want a qdisc attached no matter what. Flag those devices as such and adjust the qdisc attachment logic to check that new flag. I agree on

[net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -48,6 +48,18 @@ config

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Florian Westphal
Phil Sutter p...@nwl.cc wrote: Signed-off-by: Phil Sutter p...@nwl.cc --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: [...] +config DEFAULT_TX_QUEUE_LEN + prompt Default TX queue length (in packets) if EXPERT + int + default 1000# Ethernet wants good queues + help + Set the default value

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread David Miller
From: Phil Sutter p...@nwl.cc Date: Wed, 29 Jul 2015 23:34:28 +0200 On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: [...] +config DEFAULT_TX_QUEUE_LEN + prompt Default TX queue length (in packets) if EXPERT + int + default 1000#