Re: [net-next v2] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-03-30 Thread Vincent Bernat
❦ 30 mars 2017 06:36 -0700, Eric Dumazet  : >>> Parsing of neighbor discovery options is done earlier to ignore the >>> whole packet in case of a malformed option. Moreover, the assumption the >>> skb was linear is removed and options are extracted with >>> skb_header_pointer() as well. The check

Re: [net-next v2] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-03-30 Thread Eric Dumazet
On Wed, Mar 29, 2017 at 11:41 PM, Vincent Bernat wrote: > ❦ 29 mars 2017 22:47 +0200, Vincent Bernat : > >> Parsing of neighbor discovery options is done earlier to ignore the >> whole packet in case of a malformed option. Moreover, the assumption the >> skb was linear is removed and options are

Re: [net-next v2] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-03-29 Thread Vincent Bernat
❦ 29 mars 2017 22:47 +0200, Vincent Bernat  : > Parsing of neighbor discovery options is done earlier to ignore the > whole packet in case of a malformed option. Moreover, the assumption the > skb was linear is removed and options are extracted with > skb_header_pointer() as well. The check on th

[net-next v2] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-03-29 Thread Vincent Bernat
When an incoming frame is tagged or when GRO is disabled, the skb handled to vxlan_xmit() doesn't contain a valid transport header offset. This makes ND proxying fail. Do not rely on skb_transport_offset(). Instead, use offsets from skb_network_offset() with skb_header_pointer() to extract appropr