Re: [net PATCH 1/2] bpf: bpf_compute_data uses incorrect cb structure

2017-10-27 Thread Alexei Starovoitov
On Fri, Oct 27, 2017 at 09:45:34AM -0700, John Fastabend wrote: > SK_SKB program types use bpf_compute_data to store the end of the > packet data. However, bpf_compute_data assumes the cb is stored in the > qdisc layer format. But, for SK_SKB this is the wrong layer of the > stack for this type. >

[net PATCH 1/2] bpf: bpf_compute_data uses incorrect cb structure

2017-10-27 Thread John Fastabend
SK_SKB program types use bpf_compute_data to store the end of the packet data. However, bpf_compute_data assumes the cb is stored in the qdisc layer format. But, for SK_SKB this is the wrong layer of the stack for this type. It happens to work (sort of!) because in most cases nothing happens to