Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 17-01-25 06:52 AM, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 11:33:56PM -0800, Alexei Starovoitov wrote: >> On Tue, Jan 24, 2017 at 8:02 PM, John Fastabend >> wrote: >>> >>> Finally just to point out here are the drivers with XDP support on latest >>> net

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 11:33:56PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 24, 2017 at 8:02 PM, John Fastabend > wrote: > > > > Finally just to point out here are the drivers with XDP support on latest > > net tree, > > > > mlx/mlx5 > > mlx/mlx4 >

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Wed, Jan 25, 2017 at 01:46:46PM +0800, Jason Wang wrote: > > Then it would seem like a good thing to have another user of these paths and > > find the bugs versus letting them sit there for some poor folks who do use > > sleep/hybernate. > > > > Yes, and uncovering hypervisor bugs now is

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 08:02:29PM -0800, John Fastabend wrote: > On 17-01-24 07:23 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: > >> > >> > >> On 2017年01月25日 04:08, Michael S. Tsirkin wrote: > >>> On Tue, Jan 24, 2017 at 02:43:28PM -0500, David

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 8:02 PM, John Fastabend wrote: > > Finally just to point out here are the drivers with XDP support on latest > net tree, > > mlx/mlx5 > mlx/mlx4 > qlogic/qede > netronome/nfp > virtio_net > > And here is the

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 2017年01月25日 12:02, John Fastabend wrote: On 17-01-24 07:23 PM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: On 2017年01月25日 04:08, Michael S. Tsirkin wrote: On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S.

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 17-01-24 07:23 PM, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: >> >> >> On 2017年01月25日 04:08, Michael S. Tsirkin wrote: >>> On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S. Tsirkin" Date: Mon,

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Wed, Jan 25, 2017 at 10:57:12AM +0800, Jason Wang wrote: > > > On 2017年01月25日 04:08, Michael S. Tsirkin wrote: > > On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: > > > From: "Michael S. Tsirkin" > > > Date: Mon, 23 Jan 2017 23:08:35 +0200 > > > > > > > On

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 2017年01月25日 04:08, Michael S. Tsirkin wrote: On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: From: "Michael S. Tsirkin" Date: Mon, 23 Jan 2017 23:08:35 +0200 On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: In the small buffer case during

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 03:11:39PM -0500, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 24 Jan 2017 22:08:33 +0200 > > > On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: > >> From: "Michael S. Tsirkin" > >> Date: Mon, 23 Jan 2017

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

From: "Michael S. Tsirkin" Date: Tue, 24 Jan 2017 22:08:33 +0200 > On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Mon, 23 Jan 2017 23:08:35 +0200 >> >> > On Tue, Jan 17, 2017 at 02:19:50PM -0800, John

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Mon, 23 Jan 2017 23:08:35 +0200 > > > On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: > >> In the small buffer case during driver unload we currently use > >>

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

From: "Michael S. Tsirkin" Date: Mon, 23 Jan 2017 23:08:35 +0200 > On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: >> In the small buffer case during driver unload we currently use >> put_page instead of dev_kfree_skb. Resolve this by adding a check >> for

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On 17-01-23 01:08 PM, Michael S. Tsirkin wrote: > On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: >> In the small buffer case during driver unload we currently use >> put_page instead of dev_kfree_skb. Resolve this by adding a check >> for virtnet mode when checking XDP queue type.

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: > In the small buffer case during driver unload we currently use > put_page instead of dev_kfree_skb. Resolve this by adding a check > for virtnet mode when checking XDP queue type. Also name the > function so that the code reads

Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: > In the small buffer case during driver unload we currently use > put_page instead of dev_kfree_skb. Resolve this by adding a check > for virtnet mode when checking XDP queue type. Also name the > function so that the code reads

[net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Fixes: bb91accf2733 ("virtio-net: