Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-28 Thread Vinicius Costa Gomes
Hi, Cong Wang writes: [...] >>> >>> I am not sure how we can solve this elegantly, perhaps you should >>> extend mqprio rather than add a new one? >> >> Is the alternative hinted in the FIXME worse? Instead of passing the >> index of the hardware queue to the driver

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-28 Thread Cong Wang
On Wed, Sep 27, 2017 at 2:14 PM, Vinicius Costa Gomes wrote: > Hi, > > Cong Wang writes: > >> On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes >> wrote: >>> +static int cbs_init(struct Qdisc *sch, struct nlattr

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Guedes, Andre
On Wed, 2017-09-27 at 15:57 -0700, Jesus Sanchez-Palencia wrote: > Hi, > > > On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > > Hi, > > > > Cong Wang writes: > > > > > On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes > > > wrote:

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Jesus Sanchez-Palencia
Hi, On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > Hi, > > Cong Wang writes: > >> On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes >> wrote: >>> +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) >>> +{ >>> +

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Vinicius Costa Gomes
Hi, Cong Wang writes: > On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes > wrote: >> +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) >> +{ >> + struct cbs_sched_data *q = qdisc_priv(sch); >> + struct net_device

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Cong Wang
On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes wrote: > +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) > +{ > + struct cbs_sched_data *q = qdisc_priv(sch); > + struct net_device *dev = qdisc_dev(sch); > + > + if (!opt) > +

[next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-26 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Initially, it only