Re: [openib-general] [PATCH 04/13] Connection Manager

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 10:07 -0800, Bryan O'Sullivan wrote: > Steve Wise wrote: > > > +static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff > > *skb) > > +{ > > + struct cpl_tid_release *req; > > + > > + skb = get_skb(skb, sizeof *req, GFP_KERNEL); > > + if (!skb) { > > +

Re: [openib-general] [PATCH 04/13] Connection Manager

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: +static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb) +{ + struct cpl_tid_release *req; + + skb = get_skb(skb, sizeof *req, GFP_KERNEL); + if (!skb) { + return; + } Style micronit: no curlies for single-statement b