Re: [openib-general] [PATCH 02/13] Device Discovery and ULLD Linkage

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: +static inline void *vzmalloc(int size) +{ + void *p = vmalloc(size); + memset(p, 0, size); + return p; +} This isn't checking the return value from vmalloc. Also, we could do with a generic vzalloc and vcalloc, just as we now have kzalloc and kcalloc.

Re: [openib-general] [PATCH 02/13] Device Discovery and ULLD Linkage

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 09:53 -0800, Bryan O'Sullivan wrote: Steve Wise wrote: +static inline void *vzmalloc(int size) +{ + void *p = vmalloc(size); + memset(p, 0, size); + return p; +} This isn't checking the return value from vmalloc. Oops... Also, we could do with a