Re: [patch] d80211: fix WEP on big endian cpus

2006-09-21 Thread Jiri Benc
Sun, 10 Sep 2006 17:47:16 -0400, Michael Wu pise: This patch fixes the endian issues with the ICV in WEP, as pointed out by David Kimdon [EMAIL PROTECTED], and uses __le32 where appropriate to make things clear. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To

[patch] d80211: fix WEP on big endian cpus

2006-09-10 Thread David Kimdon
The ICV is transmitted on the network as a 4 byte little endian quantity. WEP encryption needs to swap the bytes before transmission and decryption needs to swap bytes before ICV verification. Index: wireless-dev/net/d80211/wep.c

Re: [patch] d80211: fix WEP on big endian cpus

2006-09-10 Thread Michael Buesch
On Sunday 10 September 2006 19:36, David Kimdon wrote: The ICV is transmitted on the network as a 4 byte little endian quantity. WEP encryption needs to swap the bytes before transmission and decryption needs to swap bytes before ICV verification. Holy shit, this fixes the bug I am hunting

Re: [patch] d80211: fix WEP on big endian cpus

2006-09-10 Thread Michael Wu
Huh. I assumed crc32_le gave us the result in little endian, but I guess that's wrong. I've attached another patch which basically does the same thing but adds some sparse bitwise annotations to make things clear. Also, it has a signed-off-by line. :) d80211: fix WEP on big endian cpus