Re: [patch 08/18] 3c59x: check return of pci_enable_device()

On Wed, Aug 15, 2007 at 06:30:00PM +0200, Steffen Klassert wrote: On Tue, Aug 14, 2007 at 10:54:32AM +0100, Mark Hindley wrote: On Tue, Aug 14, 2007 at 01:33:26AM -0400, Jeff Garzik wrote: I would strongly prefer that vortex_up return a value, since all the important callers of this

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

On Tue, Aug 14, 2007 at 01:33:26AM -0400, Jeff Garzik wrote: I would strongly prefer that vortex_up return a value, since all the important callers of this function can themselves return an error back to the system. we can definitely return a meaningful return value here, if

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

[EMAIL PROTECTED] wrote: From: Mark Hindley [EMAIL PROTECTED] Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley [EMAIL PROTECTED] Acked-by: Steffen Klassert [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c59x.c |8 ++-- 1

[patch 08/18] 3c59x: check return of pci_enable_device()

From: Mark Hindley [EMAIL PROTECTED] Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley [EMAIL PROTECTED] Acked-by: Steffen Klassert [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c59x.c |8 ++-- 1 files changed, 6