Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
On Wed, 18 Oct 2006 08:12:27 -0700, David Kimdon wrote: > I actually think the code reads slightly cleaner using num_algs, but > don't have a strong preference. I'd be happy to make the change if > removing num_algs is preferred. Don't know. But nobody except me objected for more than a week so I

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 03:56:07PM +0200, Jiri Benc wrote: > On Mon, 9 Oct 2006 13:11:02 -0700, David Kimdon wrote: > > --- wireless-dev.orig/net/d80211/ieee80211_sta.c > > +++ wireless-dev/net/d80211/ieee80211_sta.c > > @@ -930,8 +930,8 @@ static void ieee80211_rx_mgmt_auth(struc > > p

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread Jiri Benc
On Mon, 9 Oct 2006 13:11:02 -0700, David Kimdon wrote: > --- wireless-dev.orig/net/d80211/ieee80211_sta.c > +++ wireless-dev/net/d80211/ieee80211_sta.c > @@ -930,8 +930,8 @@ static void ieee80211_rx_mgmt_auth(struc > printk(KERN_DEBUG "%s: AP denied authentication (auth_alg=%d " >

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-09 Thread David Kimdon
Update to use ARRAY_SIZE, based on comment from Joe Perches. d80211: silence sparse warning: 'bad constant expression' Sparse does not figure out that algs[] isn't really a variable length array. The message is: net/d80211/ieee80211_sta.c:934:12: error: bad constant expression This switches alg

[patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-09 Thread David Kimdon
Sparse does not figure out that algs[] isn't really a variable length array. The message is: net/d80211/ieee80211_sta.c:934:12: error: bad constant expression This switches algs[] to be obviously a constant array, and derives the value of num_algs algs[]. The code is correct and equivalent with