Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread Jiri Pirko
Fri, Oct 13, 2017 at 04:20:38PM CEST, dsah...@gmail.com wrote: >On 10/13/17 12:26 AM, Jiri Pirko wrote: >> Thu, Oct 12, 2017 at 11:37:30PM CEST, dsah...@gmail.com wrote: >>> On 10/12/17 11:17 AM, Jiri Pirko wrote: So back to the example. First, we create 2 qdiscs. Both will share block

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread David Ahern
On 10/13/17 12:26 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:37:30PM CEST, dsah...@gmail.com wrote: >> On 10/12/17 11:17 AM, Jiri Pirko wrote: >>> So back to the example. First, we create 2 qdiscs. Both will share >>> block number 22. "22" is just an identification. If we don't pass any >>>

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread Jiri Pirko
Fri, Oct 13, 2017 at 08:31:53AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Fri, 13 Oct 2017 08:21:01 +0200 > >> Thu, Oct 12, 2017 at 07:21:48PM CEST, da...@davemloft.net wrote: >>> >>>Jiri I'm not looking at a 34 patch set, it's too large. >>> >>>Break this up

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread David Miller
From: Jiri Pirko Date: Fri, 13 Oct 2017 08:21:01 +0200 > Thu, Oct 12, 2017 at 07:21:48PM CEST, da...@davemloft.net wrote: >> >>Jiri I'm not looking at a 34 patch set, it's too large. >> >>Break this up into groups of a dozen or so patches each, no >>more. Submit them one at a

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread Jiri Pirko
Thu, Oct 12, 2017 at 11:37:30PM CEST, dsah...@gmail.com wrote: >On 10/12/17 11:17 AM, Jiri Pirko wrote: >> So back to the example. First, we create 2 qdiscs. Both will share >> block number 22. "22" is just an identification. If we don't pass any >> block number, a new one will be generated by

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread Jiri Pirko
Thu, Oct 12, 2017 at 07:21:48PM CEST, da...@davemloft.net wrote: > >Jiri I'm not looking at a 34 patch set, it's too large. > >Break this up into groups of a dozen or so patches each, no >more. Submit them one at a time and wait for each series >to be fully reviewed and integrated before moving

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-12 Thread David Ahern
On 10/12/17 11:17 AM, Jiri Pirko wrote: > So back to the example. First, we create 2 qdiscs. Both will share > block number 22. "22" is just an identification. If we don't pass any > block number, a new one will be generated by kernel: > > $ tc qdisc add dev ens7 ingress block 22 >

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-12 Thread David Miller
Jiri I'm not looking at a 34 patch set, it's too large. Break this up into groups of a dozen or so patches each, no more. Submit them one at a time and wait for each series to be fully reviewed and integrated before moving onto the next one. Thanks.

[patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-12 Thread Jiri Pirko
From: Jiri Pirko First of all, I would like to apologize for big patchset. However after couple of hours trying to figure out how to cut it, I found out it is actually not possible. I would have to add some interface in one patchset and only use it in second, which is