Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On Thu, Aug 27, 2015 at 08:40:29AM +0200, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Thu, 27 Aug 2015 08:27:04 +0200 > > > >> I'm not saying it is not possible, it certainly is. But I think that > >> for

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@resnulli.us Date: Thu, 27 Aug 2015 08:27:04 +0200 I'm not saying it is not possible, it certainly is. But I think that for example rocker internals have no value to default user, he should not care and he cannot find out what is going on there without knowledge or

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Thu, 27 Aug 2015 08:27:04 +0200 I'm not saying it is not possible, it certainly is. But I think that for example rocker internals have no value to default user, he should not care and he

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@resnulli.us Date: Thu, 27 Aug 2015 07:40:04 +0200 Switch object itselt would not help you to expose rocker internals. I don't think that you can find generic way, same for all drivers, to expose internal tables and stuff. That is hw specific. Tables are datastructures

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

Thu, Aug 27, 2015 at 08:01:15AM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Thu, 27 Aug 2015 07:40:04 +0200 Switch object itselt would not help you to expose rocker internals. I don't think that you can find generic way, same for all drivers, to expose internal

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On 26/08/15 11:21, Scott Feldman wrote: On Wed, Aug 26, 2015 at 10:49 AM, David Miller da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 09:37:57 +0200 I don't think that are much more cases like this. Therefore I think that for this cases, debugfs might be

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On Wed, Aug 26, 2015 at 10:49 AM, David Miller da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 09:37:57 +0200 I don't think that are much more cases like this. Therefore I think that for this cases, debugfs might be a good way to expose debugging stats.

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 07:52:15 +0200 They are simple statistics. But they does not fit into any existing interface. This is about EMAD packets. They are not per-netdevice, but per-pcidevice. So I cannot put them into ethtool. I see no other iface to expose

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 09:37:57 +0200 I don't think that are much more cases like this. Therefore I think that for this cases, debugfs might be a good way to expose debugging stats. Scott wanted to do similar things in rocker. DSA guys too. Every switch

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

Wed, Aug 26, 2015 at 08:08:21AM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 07:52:15 +0200 They are simple statistics. But they does not fit into any existing interface. This is about EMAD packets. They are not per-netdevice, but per-pcidevice. So

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Scott Feldman sfel...@gmail.com Date: Wed, 26 Aug 2015 11:21:59 -0700 Using another netdev doesn't seem right. Do we need a new device class for switches, and then create some common tool/interfaces for switch device class? This is probably what we will need to do. There has also been

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

Wed, Aug 26, 2015 at 08:21:59PM CEST, sfel...@gmail.com wrote: On Wed, Aug 26, 2015 at 10:49 AM, David Miller da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 09:37:57 +0200 I don't think that are much more cases like this. Therefore I think that for this

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

Tue, Aug 25, 2015 at 11:25:21PM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Mon, 24 Aug 2015 16:45:46 +0200 From: Jiri Pirko j...@mellanox.com Signed-off-by: Jiri Pirko j...@mellanox.com Signed-off-by: Ido Schimmel ido...@mellanox.com Signed-off-by: Elad Raz

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@resnulli.us Date: Mon, 24 Aug 2015 16:45:46 +0200 From: Jiri Pirko j...@mellanox.com Signed-off-by: Jiri Pirko j...@mellanox.com Signed-off-by: Ido Schimmel ido...@mellanox.com Signed-off-by: Elad Raz el...@mellanox.com Enough with this debugfs madness. Expose this

[patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

From: Jiri Pirko j...@mellanox.com Signed-off-by: Jiri Pirko j...@mellanox.com Signed-off-by: Ido Schimmel ido...@mellanox.com Signed-off-by: Elad Raz el...@mellanox.com --- drivers/net/ethernet/mellanox/mlxsw/core.c | 51 -- 1 file changed, 48 insertions(+), 3