Re: [patch net-next v2 06/13] rocker: introduce worlds infrastructure

2015-10-06 Thread Rustad, Mark D
Jiri Pirko wrote: >>> + int (*port_init)(struct rocker_port *rocker_port, void *priv, >>> +void *port_priv); >> >> Yuck, void *. Can we do better? > > I see nothing wrong with this priv usage. It's done like this on many > places. I think it is

Re: [patch net-next v2 06/13] rocker: introduce worlds infrastructure

2015-10-06 Thread Jiri Pirko
Tue, Oct 06, 2015 at 07:16:29AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This is another step on the way to per-world clean cut. Introduce world >> ops hooks which each world can implement in

[patch net-next v2 06/13] rocker: introduce worlds infrastructure

2015-10-05 Thread Jiri Pirko
From: Jiri Pirko This is another step on the way to per-world clean cut. Introduce world ops hooks which each world can implement in world-specific way. Also introduce world infrastructure including function for port worlds change. Signed-off-by: Jiri Pirko

Re: [patch net-next v2 06/13] rocker: introduce worlds infrastructure

2015-10-05 Thread Scott Feldman
On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This is another step on the way to per-world clean cut. Introduce world > ops hooks which each world can implement in world-specific way. > Also introduce world infrastructure including