From: Jiri Pirko <j...@mellanox.com>

During options set, there will be needed to hold rtnl_mutex in order to
safely call netdev notifiers.

Signed-off-by: Jiri Pirko <j...@mellanox.com>
---
 drivers/net/team/team.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index dd1504b..9814133 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2422,9 +2422,13 @@ static int team_nl_cmd_options_set(struct sk_buff *skb, 
struct genl_info *info)
        struct nlattr *nl_option;
        LIST_HEAD(opt_inst_list);
 
+       rtnl_lock();
+
        team = team_nl_team_get(info);
-       if (!team)
-               return -EINVAL;
+       if (!team) {
+               err = -EINVAL;
+               goto rtnl_unlock;
+       }
 
        err = -EINVAL;
        if (!info->attrs[TEAM_ATTR_LIST_OPTION]) {
@@ -2551,7 +2555,8 @@ static int team_nl_cmd_options_set(struct sk_buff *skb, 
struct genl_info *info)
 
 team_put:
        team_nl_team_put(team);
-
+rtnl_unlock:
+       rtnl_unlock();
        return err;
 }
 
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to