Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-30 Thread Cong Wang
On Mon, Jan 30, 2017 at 8:49 AM, Yotam Gigi wrote: > > Cong, after some thinking I think I don't really need the tcf_lock here. I > don't really care if the truncate, trunc_size, rate and tcf_action are > consistent among themselves - the only parameter that I care about is

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-30 Thread Yotam Gigi
.org>; >Guenter Roeck <li...@roeck-us.net>; Roopa Prabhu ><ro...@cumulusnetworks.com>; John Fastabend <john.fastab...@gmail.com>; >Simon Horman <simon.hor...@netronome.com>; Roman Mashak ><m...@mojatatu.com> >Subject: RE: [patch net-next v2 2/4] net/s

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-26 Thread Yotam Gigi
;<step...@networkplumber.org>; Guenter Roeck <li...@roeck-us.net>; Roopa >Prabhu <ro...@cumulusnetworks.com>; John Fastabend ><john.fastab...@gmail.com>; Simon Horman <simon.hor...@netronome.com>; >Roman Mashak <m...@mojatatu.com> >Subject: Re: [

Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-25 Thread Cong Wang
On Mon, Jan 23, 2017 at 2:07 AM, Jiri Pirko wrote: > + > +static int tcf_sample_init(struct net *net, struct nlattr *nla, > + struct nlattr *est, struct tc_action **a, int ovr, > + int bind) > +{ > + struct tc_action_net

Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-24 Thread Simon Horman
; > >step...@networkplumber.org; xiyou.wangc...@gmail.com; li...@roeck-us.net; > >ro...@cumulusnetworks.com; john.fastab...@gmail.com; m...@mojatatu.com > >Subject: Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action > > > >On Mon, Jan 23, 2017 at 11:07:09AM +0

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-24 Thread Yotam Gigi
orks.com; john.fastab...@gmail.com; m...@mojatatu.com >Subject: Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action > >On Mon, Jan 23, 2017 at 11:07:09AM +0100, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> This action allows the use

Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-24 Thread Simon Horman
On Mon, Jan 23, 2017 at 11:07:09AM +0100, Jiri Pirko wrote: > From: Yotam Gigi > > This action allows the user to sample traffic matched by tc classifier. > The sampling consists of choosing packets randomly and sampling them using > the psample module. The user can

[patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-23 Thread Jiri Pirko
From: Yotam Gigi This action allows the user to sample traffic matched by tc classifier. The sampling consists of choosing packets randomly and sampling them using the psample module. The user can configure the psample group number, the sampling rate and the packet's