Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-02 Thread Jiri Pirko
Wed, Nov 01, 2017 at 05:11:14PM CET, alexei.starovoi...@gmail.com wrote: >On Wed, Nov 01, 2017 at 09:18:03AM +0100, Jiri Pirko wrote: >> Wed, Nov 01, 2017 at 03:12:50AM CET, alexei.starovoi...@gmail.com wrote: >> >On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-01 Thread Alexei Starovoitov
On Wed, Nov 01, 2017 at 09:18:03AM +0100, Jiri Pirko wrote: > Wed, Nov 01, 2017 at 03:12:50AM CET, alexei.starovoi...@gmail.com wrote: > >On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> In sch_handle_egress and sch_handle_ingress

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-01 Thread Jiri Pirko
Wed, Nov 01, 2017 at 11:25:02AM CET, dan...@iogearbox.net wrote: >On 11/01/2017 03:12 AM, Alexei Starovoitov wrote: >> On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: >> > From: Jiri Pirko >[...] >> I don't think it's great, but I don't have any suggestions on >>

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-01 Thread Daniel Borkmann
On 11/01/2017 03:12 AM, Alexei Starovoitov wrote: On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: From: Jiri Pirko [...] I don't think it's great, but I don't have any suggestions on how to avoid it, so I'm not objecting. Just disappointed that you keep adding

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-01 Thread Jiri Pirko
Wed, Nov 01, 2017 at 03:12:50AM CET, alexei.starovoi...@gmail.com wrote: >On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> In sch_handle_egress and sch_handle_ingress tp->q is used only in order >> to update stats. So stats and filter list

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-10-31 Thread Alexei Starovoitov
On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > In sch_handle_egress and sch_handle_ingress tp->q is used only in order > to update stats. So stats and filter list are the only things that are > needed in clsact qdisc fastpath processing.

[patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-10-31 Thread Jiri Pirko
From: Jiri Pirko In sch_handle_egress and sch_handle_ingress tp->q is used only in order to update stats. So stats and filter list are the only things that are needed in clsact qdisc fastpath processing. Introduce new mini_Qdisc struct to hold those items. Also, introduce a