Re: [stmmac][bug?] endianness of Flexible RX Parser code

2018-08-06 Thread Jose Abreu
Hi Al, On 04-08-2018 02:19, Al Viro wrote: > The values passed in struct tc_u32_sel ->mask and ->val are > 32bit net-endian. Your tc_fill_entry() does this: > > data = sel->keys[0].val; > mask = sel->keys[0].mask; > > ... > entry->frag_ptr = frag; >

[stmmac][bug?] endianness of Flexible RX Parser code

2018-08-03 Thread Al Viro
The values passed in struct tc_u32_sel ->mask and ->val are 32bit net-endian. Your tc_fill_entry() does this: data = sel->keys[0].val; mask = sel->keys[0].mask; ... entry->frag_ptr = frag; entry->val.match_en = (mask << (rem * 8)) &