Re: 2.6.21-rc5-mm3: fix e1000 compilation

2007-03-30 Thread Kok, Auke
Alexey Dobriyan wrote: CC [M] drivers/net/e1000/e1000_main.o drivers/net/e1000/e1000_main.c: In function 'e1000_tso': drivers/net/e1000/e1000_main.c:2968: error: dereferencing pointer to incomplete type ... can you send me your config? I'd like to see why nobody here didn't spot

Re: 2.6.21-rc5-mm3: fix e1000 compilation

2007-03-30 Thread Alexey Dobriyan
On Fri, Mar 30, 2007 at 07:39:04AM -0700, Kok, Auke wrote: Alexey Dobriyan wrote: CC [M] drivers/net/e1000/e1000_main.o drivers/net/e1000/e1000_main.c: In function 'e1000_tso': drivers/net/e1000/e1000_main.c:2968: error: dereferencing pointer to incomplete type ... can you send

Re: 2.6.21-rc5-mm3: fix e1000 compilation

2007-03-30 Thread Randy Dunlap
On Fri, 30 Mar 2007 10:01:04 -0700 Andrew Morton wrote: On Fri, 30 Mar 2007 07:39:04 -0700 Kok, Auke [EMAIL PROTECTED] wrote: Alexey Dobriyan wrote: CC [M] drivers/net/e1000/e1000_main.o drivers/net/e1000/e1000_main.c: In function 'e1000_tso': drivers/net/e1000/e1000_main.c:2968:

Re: 2.6.21-rc5-mm3: fix e1000 compilation

2007-03-30 Thread Kok, Auke
Randy Dunlap wrote: On Fri, 30 Mar 2007 10:01:04 -0700 Andrew Morton wrote: On Fri, 30 Mar 2007 07:39:04 -0700 Kok, Auke [EMAIL PROTECTED] wrote: Alexey Dobriyan wrote: CC [M] drivers/net/e1000/e1000_main.o drivers/net/e1000/e1000_main.c: In function 'e1000_tso':

Re: 2.6.21-rc5-mm3: fix e1000 compilation

2007-03-30 Thread David Miller
From: Kok, Auke [EMAIL PROTECTED] Date: Fri, 30 Mar 2007 10:27:50 -0700 turns out that NETIF_F_TSO6 is defined even if CONFIG_IPV6 is turned off, which is what broke e1000. That in itself might be a problem. Perhaps this should be fixed in netdevice.h (gratuitous bad inline patch below) but