Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-13 Thread Marcin Ĺšlusarz
2007/8/10, Ingo Molnar <[EMAIL PROTECTED]>: > Index: linux/arch/i386/kernel/io_apic.c > === > --- linux.orig/arch/i386/kernel/io_apic.c > +++ linux/arch/i386/kernel/io_apic.c > @@ -735,7 +735,8 @@ void fastcall send_IPI_self(int vector

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jean-Baptiste Vignaud
see below > arch/i386/kernel/io_apic.c |3 ++- > arch/x86_64/kernel/genapic.c |3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > Index: linux/arch/i386/kernel/io_apic.c > === > --- linux.orig/arch/i386/kernel/i

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jean-Baptiste Vignaud
> Ingo: I think, you have to do this in x86_64, and there is probably > send_IPI_mask used for this (but I can miss something...). > > I think, Marcin will not be able to do this and report before monday, > but, > Jean-Baptiste: of course current Ingo's or Thomas' patches are > more urgent, so if

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > Ingo: I think, you have to do this in x86_64, and there is probably > send_IPI_mask used for this (but I can miss something...). indeed - full patch below. Ingo --- arch/i386/kernel/io_apic.c |3 ++- arch/x86_64/kernel/genapic.c |

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Stephen Hemminger
On Fri, 10 Aug 2007 11:33:53 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > > + } > > > > > #ifdef CONFIG_HARDIRQS_SW_RESEND > > > > > > we used the hw-resend method unconditionally, right? > > > > Right: unconditionally o

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 11:33:53AM +0200, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > > + } > > > > > #ifdef CONFIG_HARDIRQS_SW_RESEND > > > > > > we used the hw-resend method unconditionally, right? > > > > Right: unconditionally on a condition

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > + } > > > > #ifdef CONFIG_HARDIRQS_SW_RESEND > > > > we used the hw-resend method unconditionally, right? > > Right: unconditionally on a condition they are not edges... > > But, since not resending at all seems to work so goo

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:56:11AM +0200, Ingo Molnar wrote: ... > this changes the picture completely and makes the IO-APIC/local-APIC hw > retrigger code/logic the main suspect. I think you right that it's quite > bogus to hw-retrigger level irqs, and that could be confusing the > IO-APIC (or

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > [...] Well, there are probably (but need more testing) two other > > > solutions: _SW_RESEND and disabling without delay for levels > > > only... > > > > IIRC Marcin tested software-resend and it didnt fix the hang. That > > strongly points i

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:30:50AM +0200, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > Hmm. This solution is still just pampering over the real problem. > > > The delayed disable just re-sends level interrupts unnecessarily. I > > > have a fix (needs some testing)

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > Hmm. This solution is still just pampering over the real problem. > > The delayed disable just re-sends level interrupts unnecessarily. I > > have a fix (needs some testing) for this, which I send out tomorrow, > > when I'm really back from vaca

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:05:40AM +0200, Thomas Gleixner wrote: > On Thu, 2007-08-09 at 17:54 +0200, Jarek Poplawski wrote: > > I'm not sure I don't miss anything (a little in hurry now), but this > > warning's aim was purely diagnostical and nothing wrong is meant! > > Unless there is something w

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Thomas Gleixner
On Thu, 2007-08-09 at 17:54 +0200, Jarek Poplawski wrote: > I'm not sure I don't miss anything (a little in hurry now), but this > warning's aim was purely diagnostical and nothing wrong is meant! > Unless there is something wrong... Then please try to be more explicit. > > If you prefer to not se

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-09 Thread Jarek Poplawski
On Thu, Aug 09, 2007 at 11:03:03AM -0400, John Stoffel wrote: > > Hi, Hi, read below, please... > > I'm opening this ticket as a new subject, even though it looks like it > might be related to the thread "Networking dies after random time". > Sorry for the wide CC list, but since my network has

2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-09 Thread John Stoffel
Hi, I'm opening this ticket as a new subject, even though it looks like it might be related to the thread "Networking dies after random time". Sorry for the wide CC list, but since my network hasn't died since I rebooted into 2.6.23-rc2 (after 30+ days at 2.6.22-rc7), I'm wondering if the problem

2.6.23-rc2: WARNING at kernel/irq/resend.c:70 check_irq_resend()

2007-08-08 Thread Indan Zupancic
Hi, Just added an old network card, RTL-8029(AS), ne2k-pci driver, and tried to expand the network (failed because I didn't use a cross-over cable). The code snippet that spat the thing: /* * IRQ resend * * Is called with interrupts disabled and desc->lock held. */ void check_irq_resend(stru