David Miller [EMAIL PROTECTED] :
[...]
I invested 30 seconds of code reading to figure out the leak. A much
better investment of time than adding bogus comments to the Kconfig
help text don't you think? :-)
Thanks for the hint David.
I'll roll up a patch for it after the day work.
--
Just to keep the issue open, drivers/net/ipg.c currently in 2.6.24-rc6
still leaks skbuffs like a sieve. Run it for a few hours with network
traffic and the machine swaps like crazy while the oom killer goes nuts.
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index d9107e5..4fa392c
From: [EMAIL PROTECTED]
Date: 8 Jan 2008 01:52:11 -0500
@@ -172,6 +172,10 @@ config IP1000
select MII
---help---
This driver supports IP1000 gigabit Ethernet cards.
+ It works, but suffers from a memory leak. Signifcant
+ use will consume unswappable kernel
From: David Miller [EMAIL PROTECTED]
Date: Mon, 07 Jan 2008 23:07:09 -0800 (PST)
From: [EMAIL PROTECTED]
Date: 8 Jan 2008 01:52:11 -0500
@@ -172,6 +172,10 @@ config IP1000
select MII
---help---
This driver supports IP1000 gigabit Ethernet cards.
+ It works, but
ntpd. Sounds like pps leaking to me.
That's what I'd think, except that pps does no allocation in the normal
running state, so there's nothing to leak. The interrupt path just
records the time in some preallocated, static buffers and wakes up
blocked readers. The read path copies the latest
On 30 Sep 2007 03:59:56 -0400 [EMAIL PROTECTED] wrote:
ntpd. Sounds like pps leaking to me.
That's what I'd think, except that pps does no allocation in the normal
running state, so there's nothing to leak. The interrupt path just
records the time in some preallocated, static buffers and
OK. Did you try to reproduce it without the pps patch applied?
No. But I've yanked the ip1000a driver (using old crufy vendor-supplied
out-of-kernel module) and the problems are GONE.
This machine receives more data than it sends, so I'd expect acks to
outnumber real packets. Could the
On 27 Sep 2007 22:06:17 -0400 [EMAIL PROTECTED] wrote:
Uniprocessor Althlon 64, 64-bit kernel, 2G ECC RAM,
2.6.23-rc8 + linuxpps (5.0.0) + ip1000a driver.
(patch from http://marc.info/?l=linux-netdevm=118980588419882)
After a few hours of operation, ntp loses the ability to send packets.
Uniprocessor Althlon 64, 64-bit kernel, 2G ECC RAM,
2.6.23-rc8 + linuxpps (5.0.0) + ip1000a driver.
(patch from http://marc.info/?l=linux-netdevm=118980588419882)
After a few hours of operation, ntp loses the ability to send packets.
sendto() returns -EAGAIN to everything, including the 24-byte
