Re: IPv6 xfrm GSO fragmentation bug

2015-09-07 Thread Steffen Klassert
On Fri, Sep 04, 2015 at 01:21:06PM +0800, Herbert Xu wrote: > On Mon, Aug 31, 2015 at 03:35:26PM +0800, Herbert Xu wrote: > > > > I see where the bug came from. Indeed IPv6 does do fragmentation > > but only for tunnel mode. While your patch added a check that also > > affected transport mode.

Re: IPv6 xfrm GSO fragmentation bug

2015-09-03 Thread Herbert Xu
On Mon, Aug 31, 2015 at 03:35:26PM +0800, Herbert Xu wrote: > > I see where the bug came from. Indeed IPv6 does do fragmentation > but only for tunnel mode. While your patch added a check that also > affected transport mode. So in addition to the GSO fix we should > also make the MTU check

Re: IPv6 xfrm GSO fragmentation bug

2015-08-31 Thread Steffen Klassert
On Sun, Aug 30, 2015 at 04:24:32PM +0800, Herbert Xu wrote: > Hi Steffen: > > I received a bug report regarding poor IPComp performance over > IPv6: > > https://bugzilla.redhat.com/show_bug.cgi?id=1257952 > > It appears to have been caused by > > commit

Re: IPv6 xfrm GSO fragmentation bug

2015-08-31 Thread Herbert Xu
On Mon, Aug 31, 2015 at 09:19:16AM +0200, Steffen Klassert wrote: > > As far as I remember, this was to catch local message size > errors before __xfrm6_output calls ip6_fragment which would > use icmpv6_send for the error notification. IPv4 does not do > fragmentation in the xfrm4_output

IPv6 xfrm GSO fragmentation bug

2015-08-30 Thread Herbert Xu
Hi Steffen: I received a bug report regarding poor IPComp performance over IPv6: https://bugzilla.redhat.com/show_bug.cgi?id=1257952 It appears to have been caused by commit dd767856a36e00b631d65ebc4bb81b19915532d6 Author: Steffen Klassert steffen.klass...@secunet.com Date: Tue Oct