Re: possible bug in net/tc35815.c in linux-2.6.19

2007-02-26 Thread Ralf Baechle
On Sat, Feb 24, 2007 at 05:04:01PM -0500, Jeff Garzik wrote: I am a graduate student working on finding bugs in Linux drivers using an automated research tool. I think I've found a possible bug in net/tc35815.c, and I'd appreciate it if you could confirm/disconfirm it. Thanks, Philip

Re: possible bug in net/tc35815.c in linux-2.6.19

2007-02-26 Thread Atsushi Nemoto
On Mon, 26 Feb 2007 10:26:59 +, Ralf Baechle [EMAIL PROTECTED] wrote: I created my own patch for this (and one other bug), and checked it in. Really, though, someone in MIPS-land should give this driver some loving care. It is filled with bugs and 2.4-era anachronisms. Took a

Re: possible bug in net/tc35815.c in linux-2.6.19

2007-02-24 Thread Michal Piotrowski
Hi Philip, Philip Guo napisał(a): Hi, I am a graduate student working on finding bugs in Linux drivers using an automated research tool. I think I've found a possible bug in net/tc35815.c, and I'd appreciate it if you could confirm/disconfirm it. Thanks, Philip --- net/tc35815.c

Re: possible bug in net/tc35815.c in linux-2.6.19

2007-02-24 Thread Jeff Garzik
Michal Piotrowski wrote: Hi Philip, Philip Guo napisał(a): Hi, I am a graduate student working on finding bugs in Linux drivers using an automated research tool. I think I've found a possible bug in net/tc35815.c, and I'd appreciate it if you could confirm/disconfirm it. Thanks, Philip ---

Re: [BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-25 Thread Alexey Kuznetsov
Hello! So this whole idea to make run_filter() return signed integers and fail on negative is entirely flawed, it simply cannot work and retain the expected semantics which have been there forever. Actually, it can. Return value was used only as sign of error, so that the mistake was to

Re: [BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-25 Thread David Miller
From: Alexey Kuznetsov [EMAIL PROTECTED] Date: Thu, 25 Jan 2007 16:22:20 +0300 Actually, it can. Return value was used only as sign of error, so that the mistake was to return original unsigned result casted to int. Alternative fix is enclosed. To be honest, it is not better than yours:

Re: [BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-24 Thread David Miller
From: Raivis Bucis [EMAIL PROTECTED] Date: Thu, 4 Jan 2007 17:47:46 +0200 I believe I have found a bug in PF_PACKET socket filtering (introduced in linux-2.6.19). If BPF returns values larger than 0x8000u, run_filter in af_packet.c considers that as error instead of simply accepting

[ANNOUNCE] FYI: MultiTCP for linux-2.6.19

2007-01-19 Thread Daniele Lacamera
recommended by the TCP-Hybla authors in order to mitigate congestion episodes and limit the initial cwnd overshoot phenomenon respectively. A new version for linux-2.6.19 has been released at http://www.sf.net/projects/multitcp/ Hybla's authors future goal would be to produce official patches for both

[BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-04 Thread Raivis Bucis
Hello, I believe I have found a bug in PF_PACKET socket filtering (introduced in linux-2.6.19). If BPF returns values larger than 0x8000u, run_filter in af_packet.c considers that as error instead of simply accepting packet in its full length. sk_filter does not have this problem. Raivis

Re: linux-2.6.19-g3263263f build #185 failed

2006-12-11 Thread Randy Dunlap
On Mon, 11 Dec 2006 10:43:31 +0100 Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... LD drivers/media/dvb/bt8xx/built-in.o LD drivers/media/dvb/cinergyT2/built-in.o LD drivers/media/dvb/dvb-core/built-in.o LD

Re: Linux 2.6.19

2006-11-30 Thread Malte Schröder
On Thursday 30 November 2006 03:15, David Miller wrote: From: Phil Oester [EMAIL PROTECTED] Date: Wed, 29 Nov 2006 17:49:04 -0800 Getting an oops on boot here, caused by commit e81c73596704793e73e6dbb478f41686f15a4b34 titled [NET]: Fix MAX_HEADER setting. Reverting that patch fixes

Re: Linux 2.6.19

2006-11-29 Thread David Miller
From: Phil Oester [EMAIL PROTECTED] Date: Wed, 29 Nov 2006 17:49:04 -0800 Getting an oops on boot here, caused by commit e81c73596704793e73e6dbb478f41686f15a4b34 titled [NET]: Fix MAX_HEADER setting. Reverting that patch fixes things up for me. Dave? I suspect that it might be because I

Re: Linux 2.6.19

2006-11-29 Thread Phil Oester
On Wed, Nov 29, 2006 at 06:15:37PM -0800, David Miller wrote: In fact it does, the NDISC code is using MAX_HEADER incorrectly. It needs to explicitly allocate space for the struct ipv6hdr in 'len'. Luckily the TCP ipv6 code was doing it right. What a horrible bug, this patch should fix it.

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 1:43 pm, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' Hmm, that's both strange and not good :( I'm grabbing Linus' latests bits and I'll see what I can do. -- paul

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sun, 5 Nov 2006, Toralf F?rster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' net/built-in.o: In function `netlbl_socket_getattr': Ah ha! Why did you have to go and build a kernel without TCP/IP networking

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:24:07 -0500 (EST) On Sun, 5 Nov 2006, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' net/built-in.o: In function

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 7:45 pm, David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:24:07 -0500 (EST) On Sun, 5 Nov 2006, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to

CONFIG_USB_USBNET and mii_* (was Re: Linux 2.6.19-rc4)

2006-10-31 Thread Athanasius
On Mon, Oct 30, 2006 at 08:27:17PM -0800, Linus Torvalds wrote: Before I forget, I'd like to thank Adrian Bunk for his regressions listings, and ask people who are involved with those (both on the blamer and blamee sides) to follow them, and keep making sure that we get them resolved - if

Re: CONFIG_USB_USBNET and mii_* (was Re: Linux 2.6.19-rc4)

2006-10-31 Thread Randy Dunlap
On Tue, 31 Oct 2006 17:02:09 + Athanasius wrote: On Mon, Oct 30, 2006 at 08:27:17PM -0800, Linus Torvalds wrote: Before I forget, I'd like to thank Adrian Bunk for his regressions listings, and ask people who are involved with those (both on the blamer and blamee sides) to follow

linux-2.6.19-rc3-g7059abed build #99 failed

2006-10-25 Thread Toralf Förster
Hello, the build with the attached .config failed, make ends with: ... LD arch/i386/boot/compressed/vmlinux OBJCOPY arch/i386/boot/vmlinux.bin HOSTCC arch/i386/boot/tools/build BUILD arch/i386/boot/bzImage Root device is (3, 8) Boot sector 512 bytes. Setup is 4714 bytes. System

[PATCH] com20020: linux-2.6.19-rc2-gb4bd8c66 build #77 failed

2006-10-13 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] com20020.c needs to export functions if either of the ISA or PCI modules are built as loadable modules. Or they could always be exported. WARNING: com20020_found [drivers/net/arcnet/com20020-pci.ko] undefined! WARNING: com20020_check