Re: Locking validator output on DCCP

2006-06-23 Thread Ingo Molnar
* Ian McDonald <[EMAIL PROTECTED]> wrote: > OK. This is in net/ipv4/tcp_ipv4.c tcp_v4_rcv with the > bh_lock_sock_nested which I presume is clashing with the nested of > skb_clone yeah, that's exactly what happens. > Can we not do two levels nested? we can - but it needs to be thought th

Re: Locking validator output on DCCP

2006-06-22 Thread Ian McDonald
On 6/22/06, Ian McDonald <[EMAIL PROTECTED]> wrote: On 6/21/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > > As I read this it is not a recursive lock as sk_clone is occurring > > > second and is actually creating a new socket so they ar

Re: Locking validator output on DCCP

2006-06-21 Thread Ian McDonald
On 6/21/06, Ingo Molnar <[EMAIL PROTECTED]> wrote: * Herbert Xu <[EMAIL PROTECTED]> wrote: > > Can someone tell me whether I am correct in my thinking or not? If I > > am then I will work out how to tell the lock validator not to worry > > about it. > > I agree, this looks bogus. Ingo, could y

Re: Locking validator output on DCCP

2006-06-21 Thread Ian McDonald
On 6/21/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > As I read this it is not a recursive lock as sk_clone is occurring > > second and is actually creating a new socket so they are trying to > > lock on different sockets. > > > > Can som

Re: Locking validator output on DCCP

2006-06-21 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > > Can someone tell me whether I am correct in my thinking or not? If I > > am then I will work out how to tell the lock validator not to worry > > about it. > > I agree, this looks bogus. Ingo, could you please take a look? sure - Ian, could you try

Re: Locking validator output on DCCP

2006-06-21 Thread Arjan van de Ven
On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > As I read this it is not a recursive lock as sk_clone is occurring > > second and is actually creating a new socket so they are trying to > > lock on different sockets. > > > > Can someone tell me whether I am correct in my thinking or not?

Re: Locking validator output on DCCP

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 11:40:05PM +, Ian McDonald wrote: > > I am getting this when I am using DCCP with 2.6.17-rc6-mm2 with Ingo's > lock dependency patch: > > Jun 21 09:38:58 localhost kernel: [ 102.068588] > Jun 21 09:38:58 localhost kernel: [ 102.068592] > =

Locking validator output on DCCP

2006-06-20 Thread Ian McDonald
Folks, I am getting this when I am using DCCP with 2.6.17-rc6-mm2 with Ingo's lock dependency patch: Jun 21 09:38:58 localhost kernel: [ 102.068588] Jun 21 09:38:58 localhost kernel: [ 102.068592] = Jun 21 09:38:58 localhost kernel: [ 102.068602] [