Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-02 Thread Russell King - ARM Linux
On Sat, Dec 02, 2017 at 11:08:45AM +, Yan Markman wrote: > Hi Russel > > The Grygorii has raised one Additional point (about netif_carrier_off) > I just didn't want to start before finishing the previous one. > > On ifconfig-down the mac_config() called but with LINK=0. > The config has no

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-02 Thread Yan Markman
...@vger.kernel.org Subject: Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect On Fri, Dec 01, 2017 at 09:36:42AM -0800, Florian Fainelli wrote: > On 12/01/2017 09:24 AM, Russell King - ARM Linux wrote: > > On Fri, Dec 01, 2017 at 11:07:22AM -0600, Grygorii Strashko wro

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-01 Thread Russell King - ARM Linux
On Fri, Dec 01, 2017 at 09:36:42AM -0800, Florian Fainelli wrote: > On 12/01/2017 09:24 AM, Russell King - ARM Linux wrote: > > On Fri, Dec 01, 2017 at 11:07:22AM -0600, Grygorii Strashko wrote: > >> Hi Russell, > >> > >> On 11/30/2017 07:28 AM, Russell King - ARM Linux wrote: > >>> On Thu, Nov

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-01 Thread Florian Fainelli
On 12/01/2017 09:24 AM, Russell King - ARM Linux wrote: > On Fri, Dec 01, 2017 at 11:07:22AM -0600, Grygorii Strashko wrote: >> Hi Russell, >> >> On 11/30/2017 07:28 AM, Russell King - ARM Linux wrote: >>> On Thu, Nov 30, 2017 at 10:10:18AM +, Russell King - ARM Linux wrote: On Thu, Nov

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-01 Thread Russell King - ARM Linux
On Fri, Dec 01, 2017 at 11:07:22AM -0600, Grygorii Strashko wrote: > Hi Russell, > > On 11/30/2017 07:28 AM, Russell King - ARM Linux wrote: > > On Thu, Nov 30, 2017 at 10:10:18AM +, Russell King - ARM Linux wrote: > >> On Thu, Nov 30, 2017 at 08:51:21AM +, Yan Markman wrote: > >>> The

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-12-01 Thread Grygorii Strashko
Hi Russell, On 11/30/2017 07:28 AM, Russell King - ARM Linux wrote: > On Thu, Nov 30, 2017 at 10:10:18AM +, Russell King - ARM Linux wrote: >> On Thu, Nov 30, 2017 at 08:51:21AM +, Yan Markman wrote: >>> The phylink_stop is called before phylink_disconnect_phy >>> You could see in

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 10:10:18AM +, Russell King - ARM Linux wrote: > On Thu, Nov 30, 2017 at 08:51:21AM +, Yan Markman wrote: > > The phylink_stop is called before phylink_disconnect_phy > > You could see in mvpp2.c: > > > > mvpp2_stop_dev() { > > phylink_stop(port->phylink); > >

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Russell King - ARM Linux
.ray...@free-electrons.com; Nadav Haklai <nad...@marvell.com>; > m...@semihalf.com; Stefan Chulski <stef...@marvell.com>; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect > > On Wed, No

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-30 Thread Yan Markman
free-electrons.com; thomas.petazz...@free-electrons.com; miquel.ray...@free-electrons.com; Nadav Haklai <nad...@marvell.com>; m...@semihalf.com; Stefan Chulski <stef...@marvell.com>; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [EXT] Re: [PATCH net] net: phylink:

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-29 Thread Russell King - ARM Linux
On Wed, Nov 29, 2017 at 09:06:56PM +, Yan Markman wrote: > The attached p21 patch doesn't change anything. > But another one from the mail-text is good > void phylink_disconnect_phy(struct phylink *pl) > + pl->phy_state.link = false; > > There still (not for my

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-29 Thread Yan Markman
<stef...@marvell.com>; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect External Email -- On Wed, Nov 29, 2017 at 07:33:44PM +, Yan Markman w

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-29 Thread Yan Markman
ger.kernel.org; linux-ker...@vger.kernel.org Subject: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect External Email -- Oh, and lastly, please send patches to li...@armlinux.org.uk or the address I use in the s