Re: Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

2017-04-25 Thread Alexander Duyck
On Tue, Apr 25, 2017 at 8:39 AM, Lino Sanfilippo wrote: > Hi, > >> This patch doesn't look right to me. I would suggest rejecting it. >> >> The call to initialize the stats should be done when the ring is >> allocated, not in ixgbe_probe(). This should probably be done in

Aw: Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

2017-04-25 Thread Lino Sanfilippo
Hi, > This patch doesn't look right to me. I would suggest rejecting it. > > The call to initialize the stats should be done when the ring is > allocated, not in ixgbe_probe(). This should probably be done in > ixgbe_alloc_q_vector() instead. > AFAICS ixgbe_alloc_q_vector() is also called in

Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

2017-04-25 Thread Alexander Duyck
On Mon, Apr 24, 2017 at 4:00 PM, Singh, Krishneil K wrote: > > > > -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Liwei Song > Sent: Sunday, December 4, 2016 7:41 PM > To: Kirsher, Jeffrey T

RE: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

2017-04-24 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Liwei Song Sent: Sunday, December 4, 2016 7:41 PM To: Kirsher, Jeffrey T Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org;