RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-20 Thread Premkumar Jonnala
-Original Message- From: Michal Kubecek [mailto:mkube...@suse.cz] Sent: Thursday, August 20, 2015 12:00 PM To: Premkumar Jonnala Cc: Wilson, Daniel G; Scott Feldman; netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-20 Thread Premkumar Jonnala
-Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Thursday, August 20, 2015 11:09 AM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices. On Wed, Aug 19,

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-20 Thread Michal Kubecek
On Thu, Aug 20, 2015 at 05:08:51AM +, Premkumar Jonnala wrote: From: Wilson, Daniel G [mailto:daniel.wil...@intel.com] Can you extend bridge command to allow setting/getting these bridge attrs? Looks like you construct a RTM_NEWLINK IFLA_INFO_DATA msg. No changes needed to the

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-20 Thread Michal Kubecek
On Thu, Aug 20, 2015 at 06:40:01AM +, Premkumar Jonnala wrote: From: Michal Kubecek [mailto:mkube...@suse.cz] This would break existing scripts using ip to set the parameter. Is the possibility to use any of the two really that bad? There was another email on this thread where

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 2:34 AM, Premkumar Jonnala pjonn...@broadcom.com wrote: Hello Scott, Thank you for the diff and comments. Please see my comments inline. -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Tuesday, August 18, 2015 12:48 PM To: Premkumar

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Wilson, Daniel G
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Scott Feldman Sent: Wednesday, August 19, 2015 12:54 PM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
Thank you Scott. Please see inline. -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Tuesday, August 18, 2015 12:48 PM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for bridges

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 9:56 PM, Premkumar Jonnala pjonn...@broadcom.com wrote: Thank you Scott. Please see inline. -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Tuesday, August 18, 2015 12:48 PM To: Premkumar Jonnala Cc: netdev@vger.kernel.org

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
Hi Daniel, Thank you for the comments. Please see inline. -Original Message- From: Wilson, Daniel G [mailto:daniel.wil...@intel.com] Sent: Wednesday, August 19, 2015 11:33 PM To: Scott Feldman; Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: RE: [PATCH] bridge: Enable

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
-Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Thursday, August 20, 2015 10:31 AM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices. On Wed, Aug 19,

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 10:12 PM, Premkumar Jonnala pjonn...@broadcom.com wrote: -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Thursday, August 20, 2015 10:31 AM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
Hello Scott, Thank you for the diff and comments. Please see my comments inline. -Original Message- From: Scott Feldman [mailto:sfel...@gmail.com] Sent: Tuesday, August 18, 2015 12:48 PM To: Premkumar Jonnala Cc: netdev@vger.kernel.org Subject: Re: [PATCH] bridge: Enable

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-18 Thread Michal Kubecek
On Tue, Aug 18, 2015 at 09:08:42AM +, Premkumar Jonnala wrote: -Original Message- From: Rosen, Rami [mailto:rami.ro...@intel.com] Sent: Tuesday, August 18, 2015 10:25 AM To: Premkumar Jonnala; roopa Cc: netdev@vger.kernel.org Subject: RE: [PATCH] bridge: Enable

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-18 Thread Premkumar Jonnala
-Original Message- From: Rosen, Rami [mailto:rami.ro...@intel.com] Sent: Tuesday, August 18, 2015 10:25 AM To: Premkumar Jonnala; roopa Cc: netdev@vger.kernel.org Subject: RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices. Hi,

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-18 Thread Scott Feldman
On Fri, 14 Aug 2015, Premkumar Jonnala wrote: Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-18 Thread Rosen, Rami
Hi, Prem, I recall that there was a patch proposed to prevent ageing of fdb entried by bridge in kernel, when the fdb entry was added due to notification by switch device. Please see: http://www.spinics.net/lists/netdev/msg314770.html Somehow the patch is not visible in the net-next pull.

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-17 Thread Premkumar Jonnala
Hello Roopa, Thank you for the comments. Some thoughts/comments on IFLA_BR_AGEING_TIME. 1. Ageing interval using IFLA_BR_AGEING_TIME is set using 'ip link ..' command. Shouldn't bridge command be more appropriate for this? The earlier patch seems to allow configuration of other bridge

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-17 Thread Rosen, Rami
Hi, First, I agree about the need to propagate the ageing interval to switchdev devices, so that hardware based aging can be setup correctly. Second, in this occasion, I want to mention the need to turn off bridge ageing in the kernel as part of using switchdev devices. This is mentioned in

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-14 Thread roopa
On 8/13/15, 11:23 PM, Premkumar Jonnala wrote: Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer