On 9/26/18, 8:44 PM, "Samuel Mendoza-Jonas" wrote:
>Hi Vijay,
>Having had a chance to take a closer look, there is probably room for
> both this patchset and Justin's potential changes to coexist; while
> Justin's is a more general solution for sending arbitrary commands, the
> Thanks for the overview. We look forward to your patches; please
> include the same cc list as this series.
> I think it makes sense to have some OEM NCSI handing purely in the
> kenrel. This would allow eg. the MAC address of an interface to be
> correct at boot, without requiring userspace
On Thu, 2018-09-27 at 13:43 +1000, Samuel Mendoza-Jonas wrote:
> On Mon, 2018-09-24 at 17:08 -0700, Vijay Khemka wrote:
> > This patch adds OEM command to get mac address from NCSI device and and
> > configure the same to the network card.
> >
> > ncsi_cmd_arg - Modified this structure to include
On Thu, 27 Sep 2018 at 00:39, wrote:
>
> > > As I understand Justin's version adds a generic handler, using the NCSI
> > > Netlink interface to pass OEM commands and responses to and from
> > > userspace, which does the actual packet handling.
> > Thanks for the direction Sam! Justin, if you
> > As I understand Justin's version adds a generic handler, using the NCSI
> > Netlink interface to pass OEM commands and responses to and from
> > userspace, which does the actual packet handling.
> Thanks for the direction Sam! Justin, if you don't mind, can you share the
> patches you have
>Hi Vijay,
> Thanks for the patch; before I get too into a review though I'd like to
> loop in Justin (cc'd) who I know is also working on an OEM command patch.
> The changes here are very specific (eg. a command specific config option
> "CONFIG_NCSI_OEM_CMD_GET_MAC"), which is ok
On Tue, 2018-09-25 at 18:16 +, Vijay Khemka wrote:
> Hi Joel,
> Thanks, I am adding netdev mailing list here.
> Yes, this command is supported for all Mellanox card. It is as per Mellanox
> specification.
>
> Regards
> -Vijay
Hi Vijay,
Thanks for the patch; before I get too into a review
Hi Joel,
Thanks, I am adding netdev mailing list here.
Yes, this command is supported for all Mellanox card. It is as per Mellanox
specification.
Regards
-Vijay
On 9/24/18, 5:30 PM, "Joel Stanley" wrote:
Hi Vijay,
On Tue, 25 Sep 2018 at 09:39, Vijay Khemka wrote:
>
>
