RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Rajesh Borundia
-Original Message- From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com [mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On Behalf Of Vladimir Zapolskiy Sent: Tuesday, May 26, 2015 6:20 AM To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev Cc: netdev Subject:

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code is arguable, but it is already used in the driver, so

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Vladimir Zapolskiy
Hello David, On 29.05.2015 02:28, David Miller wrote: From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy v...@mleia.com Date: Fri, 29 May 2015 04:13:46 +0300 Hello David, On 29.05.2015 02:28, David Miller wrote: From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and

RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-25 Thread Rajesh Borundia
-Original Message- From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com [mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On Behalf Of Vladimir Zapolskiy Sent: Tuesday, May 26, 2015 6:20 AM To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev Cc: netdev Subject: