Re: [PATCH 2/3] qed: avoid possible stack overflow in qed_ll2_acquire_connection

2017-01-20 Thread David Miller
From: Arnd Bergmann Date: Wed, 18 Jan 2017 15:52:52 +0100 > struct qed_ll2_info is rather large, so putting it on the stack > can cause an overflow, as this warning tries to tell us: > > drivers/net/ethernet/qlogic/qed/qed_ll2.c: In function 'qed_ll2_start': >

RE: [PATCH 2/3] qed: avoid possible stack overflow in qed_ll2_acquire_connection

2017-01-19 Thread Mintz, Yuval
> 968,23 +968,19 @@ static int qed_ll2_start_ooo(struct qed_dev *cdev, { > struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev); > u8 *handle = >pf_params.iscsi_pf_params.ll2_ooo_queue_id; > - struct qed_ll2_info *ll2_info; > + struct qed_ll2_conn ll2_info; A bit confusing to