Re: [openib-general] RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-18 Thread Sean Hefty
Grant Grundler wrote: Is this code going to get invoked very often? In practice, it would be invoked when matching any listen requests originating from the CMA (RDMA connection abstraction). hrm..I'm not sure how to translate your answer into a workload. e.g. which netperf or netpipe test

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-18 Thread Bryan O'Sullivan
On Wed, 2006-01-18 at 08:08 +0100, Arjan van de Ven wrote: the dual license text needs a bit of clarification I suspect to make explicit that the or BSD part only applies when used entirely outside the linux kernel. (that already is the case, just it's not explicit. Making that explicit would

RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch extends matching connection requests to listens in the Infiniband CM to include private data. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/cm.c

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Stephen Hemminger
Minor nits. On Tue, 17 Jan 2006 15:24:37 -0800 Sean Hefty [EMAIL PROTECTED] wrote: The following patch extends matching connection requests to listens in the Infiniband CM to include private data. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- +static void cm_mask_compare_data(u8

RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
+static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask) static void cm_mask_compare_data(u8 *dst, const u8 *src, u8 *mask) but I would rename it to cm_mask_copy since it doesn't really do a compare. I'll change this. The function is masking the data to use in the comparison, but I can

Re: [openib-general] RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Grant Grundler
On Tue, Jan 17, 2006 at 03:24:37PM -0800, Sean Hefty wrote: +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask) +{ + int i; + + for (i = 0; i IB_CM_PRIVATE_DATA_COMPARE_SIZE; i++) + dst[i] = src[i] mask[i]; +} Is this code going to get invoked very often?

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Arjan van de Ven
flamebait Also should infiniband exports be EXPORT_SYMBOL_GPL, to make it clear that binary drivers for this are not allowed?? /flamebait the dual license text needs a bit of clarification I suspect to make explicit that the or BSD part only applies when used entirely outside the linux