RE: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-19 Thread Yuval Mintz
> On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz > wrote: > >> +enum devlink_autoneg_protocol { > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, > >> +

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-19 Thread Steve Lin
On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz wrote: >> +enum devlink_autoneg_protocol { >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, >> +

RE: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-19 Thread Yuval Mintz
> +enum devlink_autoneg_protocol { > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, > + DEVLINK_AUTONEG_PROTOCOL_BAM, /* Broadcom > Autoneg Mode */ > +

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 03:22:03PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 9:01 AM, Jiri Pirko wrote: >> Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >>>On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote:

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 9:01 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: >>> >>> You need to split the config option to those that are per-port and to >>>

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: >> >> You need to split the config option to those that are per-port and to >> those that are per-asic. For each family, you have to use ither >>

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: > > You need to split the config option to those that are per-port and to > those that are per-asic. For each family, you have to use ither > devlink_port of devlink handle. Also, you need to split into those that are >

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Jiri Pirko
Tue, Oct 17, 2017 at 10:44:26PM CEST, steven.l...@broadcom.com wrote: >Extending DEVLINK_ATTR_PERM_CFG (permanent/NVRAM device configuration) >to include persistent configuration of device link settings: > >DEVLINK_ATTR_PERM_CFG_AUTONEG_PROTOCOL: Configure default autoneg >protocol; use enum