Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-31 Thread Claudiu.Beznea
On 30.10.2018 21:36, Tristram Ha - C24268 wrote: >> Could you check on your side that applying this on top of your patch, your >> scenario is still working? >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c >> b/drivers/net/ethernet/cadence/macb_main.c >> index

RE: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-30 Thread Tristram.Ha
> Could you check on your side that applying this on top of your patch, your > scenario is still working? > > diff --git a/drivers/net/ethernet/cadence/macb_main.c > b/drivers/net/ethernet/cadence/macb_main.c > index 1d86b4d5645a..e1347d6d1b50 100644 > ---

Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-30 Thread Claudiu.Beznea
On 29.10.2018 23:40, Tristram Ha - C24268 wrote: >> Could you, please, tell me if the above variable was false in your case? >> >> bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb); >> >> If yes, then, the proper fix would be as follows: >> >> diff --git

RE: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-29 Thread Tristram.Ha
> Could you, please, tell me if the above variable was false in your case? > > bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb); > > If yes, then, the proper fix would be as follows: > > diff --git a/drivers/net/ethernet/cadence/macb_main.c > b/drivers/net/ethernet/cadence/macb_main.c

Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-29 Thread Claudiu.Beznea
Hi Tristram, Could you, please, tell me if the above variable was false in your case? bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb); If yes, then, the proper fix would be as follows: diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c

Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-25 Thread Florian Fainelli
On 10/25/18 11:32 AM, David Miller wrote: > From: > Date: Wed, 24 Oct 2018 14:51:23 -0700 > >> From: Tristram Ha >> >> Socket buffer is not re-created when headroom is 2 and tailroom is 1. >> >> Signed-off-by: Tristram Ha > > Applied. No fixes tag? -- Florian

Re: [PATCH net] net: ethernet: cadence: fix socket buffer corruption problem

2018-10-25 Thread David Miller
From: Date: Wed, 24 Oct 2018 14:51:23 -0700 > From: Tristram Ha > > Socket buffer is not re-created when headroom is 2 and tailroom is 1. > > Signed-off-by: Tristram Ha Applied.