Re: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-19 Thread David Miller
From: Chunhao Lin Date: Thu, 18 Feb 2016 22:57:07 +0800 > There will be a log spam when there is no cable plugged. > Please refer to following links. > https://bugzilla.kernel.org/show_bug.cgi?id=104351 > https://bugzilla.kernel.org/show_bug.cgi?id=107421 > > This issue is

RE: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-19 Thread Hau
> Chunhao Lin : > [...] > > I add checking driver's pm runtime status in rtl8169_get_stats64() to fix > > this issue. > > Would you consider taking the device out of suspended mode during > rtl8169_get_stats64 to prevent outdated stats ? > When in runtime suspend, it mean

Re: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-18 Thread Francois Romieu
Chunhao Lin : [...] > I add checking driver's pm runtime status in rtl8169_get_stats64() to fix > this issue. Would you consider taking the device out of suspended mode during rtl8169_get_stats64 to prevent outdated stats ? -- Ueimor