Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Andrew Lunn
.@free-electrons.com; > > netdev@vger.kernel.org > > Subject: Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver > > > > Hi Antione. > > > > > How would you name it if not "comphy-cp110"? > > > > Good question... > &g

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Antoine Tenart
Hi Stefan, On Thu, Aug 24, 2017 at 01:57:04PM +, Stefan Chulski wrote: > > > > How would you name it if not "comphy-cp110"? > > > > Good question... > > > > '7000-cpmphy-cp110' > > '8000-cpmphy-cp110' > > > > ?? > > > > Andrew > > A8K Marvell SoC has two South Bridge communication

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Antoine Tenart
Hi Andrew, On Thu, Aug 24, 2017 at 03:45:04PM +0200, Andrew Lunn wrote: > > + for_each_available_child_of_node(pdev->dev.of_node, child) { > > + struct mvebu_comphy_lane *lane; > > + struct phy *phy; > > + int ret; > > + u32 val; > > + > > + ret

RE: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Stefan Chulski
om; gregory.clem...@free-electrons.com; > thomas.petazz...@free-electrons.com; Nadav Haklai <nad...@marvell.com>; > li...@armlinux.org.uk; linux-ker...@vger.kernel.org; m...@semihalf.com; > Stefan Chulski <stef...@marvell.com>; miquel.ray...@free-electrons.com; > netdev@vger.kern

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Andrew Lunn
Hi Antione. > How would you name it if not "comphy-cp110"? Good question... '7000-cpmphy-cp110' '8000-cpmphy-cp110' ?? Andrew

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Antoine Tenart
Hi Andrew, On Thu, Aug 24, 2017 at 03:39:22PM +0200, Andrew Lunn wrote: > > +static const struct mvebu_comhy_conf mvebu_comphy_modes[] = { > > + /* lane 0 */ > > + MVEBU_COMPHY_CONF(0, 1, PHY_MODE_SGMII, 0x1), > > + /* lane 1 */ > > + MVEBU_COMPHY_CONF(1, 2, PHY_MODE_SGMII, 0x1), > > +

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Andrew Lunn
> + for_each_available_child_of_node(pdev->dev.of_node, child) { > + struct mvebu_comphy_lane *lane; > + struct phy *phy; > + int ret; > + u32 val; > + > + ret = of_property_read_u32(child, "reg", ); > + if (ret < 0) { > +

Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver

2017-08-24 Thread Andrew Lunn
> +static const struct mvebu_comhy_conf mvebu_comphy_modes[] = { > + /* lane 0 */ > + MVEBU_COMPHY_CONF(0, 1, PHY_MODE_SGMII, 0x1), > + /* lane 1 */ > + MVEBU_COMPHY_CONF(1, 2, PHY_MODE_SGMII, 0x1), > + /* lane 2 */ > + MVEBU_COMPHY_CONF(2, 0, PHY_MODE_SGMII, 0x1), > +