RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-03 Thread Gao Feng
> From: Xin Long [mailto:lucien@gmail.com] > Sent: Wednesday, May 3, 2017 7:26 PM > On Wed, May 3, 2017 at 2:37 PM, Gao Feng wrote: > >> From: Xin Long [mailto:lucien@gmail.com] > >> Sent: Wednesday, May 3, 2017 1:38 PM > >> On Wed, May 3, 2017 at 10:07 AM, Gao

Re: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-03 Thread Xin Long
On Wed, May 3, 2017 at 2:37 PM, Gao Feng wrote: >> From: Xin Long [mailto:lucien@gmail.com] >> Sent: Wednesday, May 3, 2017 1:38 PM >> On Wed, May 3, 2017 at 10:07 AM, Gao Feng >> wrote: >> >> From: netdev-ow...@vger.kernel.org >> >>

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-03 Thread Gao Feng
> From: Xin Long [mailto:lucien@gmail.com] > Sent: Wednesday, May 3, 2017 1:38 PM > On Wed, May 3, 2017 at 10:07 AM, Gao Feng > wrote: > >> From: netdev-ow...@vger.kernel.org > >> [mailto:netdev-ow...@vger.kernel.org] > >> On Behalf Of Xin Long > >> Sent: Wednesday,

Re: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Xin Long
On Wed, May 3, 2017 at 10:07 AM, Gao Feng wrote: >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Xin Long >> Sent: Wednesday, May 3, 2017 12:59 AM >> On Tue, May 2, 2017 at 7:03 PM, Gao Feng wrote: >> >>

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Gao Feng
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Xin Long > Sent: Wednesday, May 3, 2017 12:59 AM > On Tue, May 2, 2017 at 7:03 PM, Gao Feng wrote: > >> From: Xin Long [mailto:lucien@gmail.com] > >> Sent: Tuesday, May 2, 2017

Re: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Xin Long
On Tue, May 2, 2017 at 7:03 PM, Gao Feng wrote: >> From: Xin Long [mailto:lucien@gmail.com] >> Sent: Tuesday, May 2, 2017 3:56 PM >> On Sat, Apr 29, 2017 at 11:51 AM, wrote: >> > From: Gao Feng > [...] >> > -static

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Gao Feng
> From: Xin Long [mailto:lucien@gmail.com] > Sent: Tuesday, May 2, 2017 3:56 PM > On Sat, Apr 29, 2017 at 11:51 AM, wrote: > > From: Gao Feng [...] > > -static void veth_dev_free(struct net_device *dev) > > +static void

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Gao Feng
> From: David Ahern [mailto:d...@cumulusnetworks.com] > Sent: Monday, May 1, 2017 11:08 PM > On 4/28/17 9:51 PM, gfree.w...@foxmail.com wrote: > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c index > > 8c39d6d..418376a 100644 > > --- a/drivers/net/veth.c > > +++ b/drivers/net/veth.c > > @@

Re: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-02 Thread Xin Long
On Sat, Apr 29, 2017 at 11:51 AM, wrote: > From: Gao Feng > > The veth driver allocates some resources in its ndo_init func, and > free them in its destructor func. Then there is one memleak that some > errors happen after register_netdevice

Re: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

2017-05-01 Thread David Ahern
On 4/28/17 9:51 PM, gfree.w...@foxmail.com wrote: > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index 8c39d6d..418376a 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -224,9 +224,21 @@ static int veth_dev_init(struct net_device *dev) > return 0; > } > >