RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

.@vger.kernel.org; > netdev@vger.kernel.org; thunderbolt-linux <thunderbolt-li...@intel.com>; > Westerberg, Mika <mika.westerb...@intel.com> > Subject: RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM > (firmware) > > Hi Tomas, > Thanks for your commen

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi, Amir, >This patch is the communication with the FW. >The network functionality is added in the next patches in the series >and with it, more messages from FW. >Indeed this function always returns true in this patch, >but while writing it, I predicted that the network functionality will

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

On Thu, Jul 14 2016, 06:08 PM, Rosen, Rami wrote: > Hi Amir, Hi Rami, > Here are my 2 cents: > > This method always returns true, should be void (unless you will change > PDF_ERROR_NOTIFICATION or other pdf values to return false), and > likewise its invocation should not check return value. >

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Amir, Here are my 2 cents: This method always returns true, should be void (unless you will change PDF_ERROR_NOTIFICATION or other pdf values to return false), and likewise its invocation should not check return value. > +static bool nhi_msg_from_icm_analysis(struct tbt_nhi_ctxt

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Tomas, Thanks for your comments. On Thu, Jul 14 2016, 03:44 PM, Winkler, Tomas wrote: > > +/* NHI genetlink commands */ > > +enum { > > + NHI_CMD_UNSPEC, > > + NHI_CMD_SUBSCRIBE, > > + NHI_CMD_UNSUBSCRIBE, > > + NHI_CMD_QUERY_INFORMATION, > > + NHI_CMD_MSG_TO_ICM, > > +

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

> > Firmware-based (a.k.a ICM - Intel Connection Manager) controller is > used for establishing and maintaining the Thunderbolt Networking > connection. We need to be able to communicate with it. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/Makefile |